Skip to content

Switch from dockerfile maven plugin to jib #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gs-manvig wants to merge 1 commit into from
+243 −115
Closed

Switch from dockerfile maven plugin to jib #4265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions legend-engine-config/legend-engine-server/legend-engine-server-http-server/Dockerfile
View file
Open in desktop

This file was deleted.

137 changes: 118 additions & 19 deletions legend-engine-config/legend-engine-server/legend-engine-server-http-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,24 +1269,49 @@
<build>
<plugins>
<plugin>
<groupId>com.spotify</groupId>
<artifactId>dockerfile-maven-plugin</artifactId>
<inherited>false</inherited>
<groupId>com.google.cloud.tools</groupId>
<artifactId>jib-maven-plugin</artifactId>
<executions>
<execution>
<phase>deploy</phase>
<phase>install</phase>
<goals>
<goal>build</goal>
<goal>tag</goal>
<goal>push</goal>
</goals>
</execution>
</executions>
<configuration>
<tag>${project.version}</tag>
<username>${env.DOCKER_USERNAME}</username>
<password>${env.DOCKER_PASSWORD}</password>
<repository>registry.hub.docker.com/${env.DOCKER_USERNAME}/${project.artifactId}</repository>
<from>
<image>eclipse-temurin:11-jre</image>
</from>
<to>
<tags>${project.version}</tags>
<auth>
<username>${env.DOCKER_USERNAME}</username>
<password>${env.DOCKER_PASSWORD}</password>
</auth>
<image>registry.hub.docker.com/${env.DOCKER_USERNAME}/${project.artifactId}</image>
</to>
<container>
<mainClass>org.finos.legend.engine.server.Server</mainClass>
<args>
<arg>server</arg>
<arg>/config/config.json</arg>
</args>
<jvmFlags>
<jvmFlag>-XX:+ExitOnOutOfMemoryError</jvmFlag>
<jvmFlag>-XX:MaxRAMPercentage=60</jvmFlag>
<jvmFlag>-Xss4M</jvmFlag>
<jvmFlag>-Dfile.encoding=UTF8</jvmFlag>
</jvmFlags>
</container>
<extraDirectories>
<paths>
<path>
<from>src/main/resources/docker/config</from>
<into>/config</into>
</path>
</paths>
</extraDirectories>
</configuration>
</plugin>
</plugins>
Expand All @@ -1297,24 +1322,98 @@
<build>
<plugins>
<plugin>
<groupId>com.spotify</groupId>
<artifactId>dockerfile-maven-plugin</artifactId>
<inherited>false</inherited>
<groupId>com.google.cloud.tools</groupId>
<artifactId>jib-maven-plugin</artifactId>
<executions>
<execution>
<phase>install</phase>
<goals>
<goal>build</goal>
<goal>tag</goal>
<goal>push</goal>
</goals>
</execution>
</executions>
<configuration>
<tag>snapshot</tag>
<username>${env.DOCKER_USERNAME}</username>
<password>${env.DOCKER_PASSWORD}</password>
<repository>registry.hub.docker.com/${env.DOCKER_USERNAME}/${project.artifactId}</repository>
<from>
<image>eclipse-temurin:11-jre</image>
</from>
<to>
<tags>snapshot</tags>
<auth>
<username>${env.DOCKER_USERNAME}</username>
<password>${env.DOCKER_PASSWORD}</password>
</auth>
<image>registry.hub.docker.com/${env.DOCKER_USERNAME}/${project.artifactId}</image>
</to>
<container>
<mainClass>org.finos.legend.engine.server.Server</mainClass>
<args>
<arg>server</arg>
<arg>/config/config.json</arg>
</args>
<jvmFlags>
<jvmFlag>-XX:+ExitOnOutOfMemoryError</jvmFlag>
<jvmFlag>-XX:MaxRAMPercentage=60</jvmFlag>
<jvmFlag>-Xss4M</jvmFlag>
<jvmFlag>-Dfile.encoding=UTF8</jvmFlag>
</jvmFlags>
</container>
<extraDirectories>
<paths>
<path>
<from>src/main/resources/docker/config</from>
<into>/config</into>
</path>
</paths>
</extraDirectories>
</configuration>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>docker-local</id>
<build>
<plugins>
<plugin>
<groupId>com.google.cloud.tools</groupId>
<artifactId>jib-maven-plugin</artifactId>
<executions>
<execution>
<phase>install</phase>
<goals>
<goal>dockerBuild</goal>
</goals>
</execution>
</executions>
<configuration>
<from>
<image>eclipse-temurin:11-jre</image>
</from>
<to>
<tags>${project.version}-local</tags>
<image>${project.artifactId}</image>
</to>
<container>
<mainClass>org.finos.legend.engine.server.Server</mainClass>
<args>
<arg>server</arg>
<arg>/config/config.json</arg>
</args>
<jvmFlags>
<jvmFlag>-XX:+ExitOnOutOfMemoryError</jvmFlag>
<jvmFlag>-XX:MaxRAMPercentage=60</jvmFlag>
<jvmFlag>-Xss4M</jvmFlag>
<jvmFlag>-Dfile.encoding=UTF8</jvmFlag>
</jvmFlags>
</container>
<extraDirectories>
<paths>
<path>
<from>src/main/resources/docker/config</from>
<into>/config</into>
</path>
</paths>
</extraDirectories>
</configuration>
</plugin>
</plugins>
Expand Down
23 changes: 0 additions & 23 deletions ...gine-core-pure/legend-engine-pure-ide/legend-engine-pure-ide-light-http-server/Dockerfile
View file
Open in desktop

This file was deleted.

140 changes: 121 additions & 19 deletions ...-engine-core-pure/legend-engine-pure-ide/legend-engine-pure-ide-light-http-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,24 +454,50 @@
<build>
<plugins>
<plugin>
<groupId>com.spotify</groupId>
<artifactId>dockerfile-maven-plugin</artifactId>
<inherited>false</inherited>
<groupId>com.google.cloud.tools</groupId>
<artifactId>jib-maven-plugin</artifactId>
<executions>
<execution>
<phase>deploy</phase>
<phase>install</phase>
<goals>
<goal>build</goal>
<goal>tag</goal>
<goal>push</goal>
</goals>
</execution>
</executions>
<configuration>
<tag>${project.version}</tag>
<username>${env.DOCKER_USERNAME}</username>
<password>${env.DOCKER_PASSWORD}</password>
<repository>registry.hub.docker.com/${env.DOCKER_USERNAME}/${project.artifactId}</repository>
<from>
<image>eclipse-temurin:11-jre</image>
</from>
<to>
<tags>${project.version}</tags>
<auth>
<username>${env.DOCKER_USERNAME}</username>
<password>${env.DOCKER_PASSWORD}</password>
<image>registry.hub.docker.com/${env.DOCKER_USERNAME}/${project.artifactId}</image>
</auth>
</to>
<container>
<mainClass>org.finos.legend.engine.ide.PureIDELight_NoExtension</mainClass>
<args>
<arg>server</arg>
<arg>/config/ideLightConfig.json</arg>
</args>
<jvmFlags>
<jvmFlag>-XX:+ExitOnOutOfMemoryError</jvmFlag>
<jvmFlag>-XX:MaxRAMPercentage=60</jvmFlag>
<jvmFlag>-Xss4M</jvmFlag>
<jvmFlag>-Dfile.encoding=UTF8</jvmFlag>
</jvmFlags>
</container>
<extraDirectories>
<paths>
<path>
<from>src/main/resources</from>
<into>/config</into>
<includes>ideLightConfig.json</includes>
</path>
</paths>
</extraDirectories>
</configuration>
</plugin>
</plugins>
Expand All @@ -482,24 +508,100 @@
<build>
<plugins>
<plugin>
<groupId>com.spotify</groupId>
<artifactId>dockerfile-maven-plugin</artifactId>
<inherited>false</inherited>
<groupId>com.google.cloud.tools</groupId>
<artifactId>jib-maven-plugin</artifactId>
<executions>
<execution>
<phase>install</phase>
<goals>
<goal>build</goal>
<goal>tag</goal>
<goal>push</goal>
</goals>
</execution>
</executions>
<configuration>
<tag>snapshot</tag>
<username>${env.DOCKER_USERNAME}</username>
<password>${env.DOCKER_PASSWORD}</password>
<repository>registry.hub.docker.com/${env.DOCKER_USERNAME}/${project.artifactId}</repository>
<from>
<image>eclipse-temurin:11-jre</image>
</from>
<to>
<tags>snapshot</tags>
<auth>
<username>${env.DOCKER_USERNAME}</username>
<password>${env.DOCKER_PASSWORD}</password>
</auth>
<image>registry.hub.docker.com/${env.DOCKER_USERNAME}/${project.artifactId}</image>
</to>
<container>
<mainClass>org.finos.legend.engine.ide.PureIDELight_NoExtension</mainClass>
<args>
<arg>server</arg>
<arg>/config/ideLightConfig.json</arg>
</args>
<jvmFlags>
<jvmFlag>-XX:+ExitOnOutOfMemoryError</jvmFlag>
<jvmFlag>-XX:MaxRAMPercentage=60</jvmFlag>
<jvmFlag>-Xss4M</jvmFlag>
<jvmFlag>-Dfile.encoding=UTF8</jvmFlag>
</jvmFlags>
</container>
<extraDirectories>
<paths>
<path>
<from>src/main/resources</from>
<into>/config</into>
<includes>ideLightConfig.json</includes>
</path>
</paths>
</extraDirectories>
</configuration>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>docker-local</id>
<build>
<plugins>
<plugin>
<groupId>com.google.cloud.tools</groupId>
<artifactId>jib-maven-plugin</artifactId>
<executions>
<execution>
<phase>install</phase>
<goals>
<goal>dockerBuild</goal>
</goals>
</execution>
</executions>
<configuration>
<from>
<image>eclipse-temurin:11-jre</image>
</from>
<to>
<tags>${project.version}-local</tags>
<image>${project.artifactId}</image>
</to>
<container>
<mainClass>org.finos.legend.engine.ide.PureIDELight_NoExtension</mainClass>
<args>
<arg>server</arg>
<arg>/config/ideLightConfig.json</arg>
</args>
<jvmFlags>
<jvmFlag>-XX:+ExitOnOutOfMemoryError</jvmFlag>
<jvmFlag>-XX:MaxRAMPercentage=60</jvmFlag>
<jvmFlag>-Xss4M</jvmFlag>
<jvmFlag>-Dfile.encoding=UTF8</jvmFlag>
</jvmFlags>
</container>
<extraDirectories>
<paths>
<path>
<from>src/main/resources</from>
<into>/config</into>
<includes>ideLightConfig.json</includes>
</path>
</paths>
</extraDirectories>
</configuration>
</plugin>
</plugins>
Expand Down
Loading
Loading