Skip to content

Fix EnumHelper.resolveToEnum for stubs other than EnumStubs#1208

Merged
kevin-m-knight-gs merged 1 commit intofinos:masterfrom
kevin-m-knight-gs:enum_helper
Mar 4, 2026
Merged

Fix EnumHelper.resolveToEnum for stubs other than EnumStubs#1208
kevin-m-knight-gs merged 1 commit intofinos:masterfrom
kevin-m-knight-gs:enum_helper

Conversation

@kevin-m-knight-gs
Copy link
Contributor

Fix EnumHelper.resolveToEnum for stubs other than EnumStubs. Previously, the code assumed that if a Enum was contained within a stub, it would be an EnumStub. However, it could also be a GrammarInfoStub. This generalizes it so that it will work regardless of what kind of stub.

@kevin-m-knight-gs kevin-m-knight-gs requested a review from a team as a code owner March 4, 2026 19:45
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Test Results

   591 files  ±0     591 suites  ±0   1h 31m 9s ⏱️ -36s
4 792 tests ±0  4 752 ✔️ ±0  40 💤 ±0  0 ±0 
5 727 runs  ±0  5 687 ✔️ ±0  40 💤 ±0  0 ±0 

Results for commit c2ed3aa. ± Comparison against base commit 36ee7c6.

@kevin-m-knight-gs kevin-m-knight-gs merged commit ef0b3cc into finos:master Mar 4, 2026
4 checks passed
@kevin-m-knight-gs kevin-m-knight-gs deleted the enum_helper branch March 5, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants