Skip to content

Conversation

@gs-gunjan
Copy link
Contributor

Summary

PR contains the following changes:

  1. Users will now select environment before selecting data products
  2. Users environment will be auto resolved making sure saved views can be opened with right entitlements
  3. Improve UI for data product name (title + id)

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@gs-gunjan gs-gunjan requested a review from a team as a code owner January 5, 2026 05:49
@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2026

🦋 Changeset detected

Latest commit: 9cdc829

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@finos/legend-server-lakehouse Patch
@finos/legend-application-data-cube Patch
@finos/legend-graph Patch
@finos/legend-application-marketplace Patch
@finos/legend-application-studio Patch
@finos/legend-extension-dsl-data-product Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-code-editor Patch
@finos/legend-data-cube Patch
@finos/legend-extension-application-studio-depot-dashboard Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram-studio Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-lego Patch
@finos/legend-query-builder Patch
@finos/legend-server-marketplace Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-marketplace-bootstrap Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-marketplace-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 23.74101% with 212 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.82%. Comparing base (d59e014) to head (9cdc829).
⚠️ Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
.../source/LakehouseConsumerDataCubeSourceBuilder.tsx 2.70% 144 Missing ⚠️
...d-server-lakehouse/src/helpers/V1_IngestHelpers.ts 0.00% 30 Missing ⚠️
...rce/LakehouseConsumerDataCubeSourceBuilderState.ts 6.89% 27 Missing ⚠️
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 86.27% 7 Missing ⚠️
.../components/builder/LegendDataCubeSourceViewer.tsx 0.00% 3 Missing ⚠️
...kehouse/entitlements/V1_EntitlementsDataProduct.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4750      +/-   ##
==========================================
+ Coverage   46.81%   46.82%   +0.01%     
==========================================
  Files        2559     2559              
  Lines      467237   467296      +59     
  Branches    13992    18178    +4186     
==========================================
+ Hits       218731   218817      +86     
+ Misses     248022   247970      -52     
- Partials      484      509      +25     
Files with missing lines Coverage Δ
...ts/__test-utils__/LegendDataCubeStoreTestUtils.tsx 100.00% <100.00%> (ø)
.../src/stores/builder/LegendDataCubeCreatorState.tsx 52.58% <ø> (+0.24%) ⬆️
...rc/stores/model/LakehouseConsumerDataCubeSource.ts 73.97% <100.00%> (ø)
...kehouse/entitlements/V1_EntitlementsDataProduct.ts 52.68% <0.00%> (-0.58%) ⬇️
.../components/builder/LegendDataCubeSourceViewer.tsx 58.25% <0.00%> (ø)
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 44.97% <86.27%> (+0.21%) ⬆️
...rce/LakehouseConsumerDataCubeSourceBuilderState.ts 18.55% <6.89%> (+1.12%) ⬆️
...d-server-lakehouse/src/helpers/V1_IngestHelpers.ts 0.00% <0.00%> (ø)
.../source/LakehouseConsumerDataCubeSourceBuilder.tsx 12.30% <2.70%> (-3.64%) ⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

}}
value={
sourceBuilder.selectedDataProduct
sourceBuilder.envMode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the default behaviour when creating a new consumer query. is the envMode null ?
if so we should make the default production.
we want the dropdowns to assume prod unless the user goes and switches it to prod parallel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeh that makes sense

@MauricioUyaguari MauricioUyaguari merged commit d4177ed into finos:master Jan 12, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants