fix: preserve JsonSchema.Net assembly during trimming #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ILLink descriptor to preserve the entire JsonSchema.Net assembly instead of specific types. The library uses extensive reflection for JSON Schema validation which requires all types to be available. **Changes**: - Preserve JsonSchema.Net assembly completely (preserve="all") - Keep resource preservation with correct dotted naming convention - Remove type-specific preservation (was too narrow) **Testing**: Verified locally that trimmed executable correctly validates both valid and invalid IR files with proper IsValid results. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This was referenced Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Deployment workflow failing on all platforms after PR #199 merge with E2E test regression:
IsValid=falsebut gettingIsValid=truefor invalid filesRoot Cause
The initial ILLink.Descriptors.xml in PR #199 was too narrow - it only preserved specific types and resources, but JsonSchema.Net uses extensive reflection for JSON Schema validation that requires the entire assembly to be preserved during trimming.
Solution
Update ILLink.Descriptors.xml to preserve the entire JsonSchema.Net assembly with
preserve="all":Testing
✅ Verified locally with trimmed executable:
IsValid=falseIsValid=trueImpact
Related
🤖 Generated with Claude Code