chore: remove outdated morphir-elm subtree and related Elm code #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move skill definitions from single files to directory structure: - morphir-developer.md -> morphir-developer/SKILL.md - release-manager.md -> release-manager/SKILL.md - Remove skills.json (no longer needed)
Remove legacy Elm code that is no longer needed for the Go implementation: 1. morphir-elm/ - Outdated git subtree of finos/morphir-elm causing: - Renovate flagging vulnerability issues in stale npm dependencies - 16MB of unused code not relevant to the Go implementation - Confusion about which code is authoritative 2. src/Morphir/ - Elm source code for defunct morphir-elm-compiler package 3. packages/morphir-elm-compiler/ - Incomplete TypeScript/Elm hybrid compiler package that is not actively maintained The following are intentionally kept: - tests/bdd/testdata/morphir-elm/ - Test fixtures fetched from canonical repo References to finos/morphir-elm in docs/comments remain as they point to the canonical repository which is the authoritative source. Closes: morphir-d3g
✅ Deploy Preview for angry-raman-7c44f6 canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove legacy Elm code that is no longer needed for the Go implementation:
morphir-elm/ - Outdated git subtree of finos/morphir-elm (557 files, 308K lines)
src/Morphir/ - Elm source code for defunct morphir-elm-compiler package (~200 files)
packages/morphir-elm-compiler/ - Incomplete TypeScript/Elm hybrid compiler (~100 files)
Total: 861 files, 376,012 lines removed
What was kept
tests/bdd/testdata/morphir-elm/- Test fixtures fetched from canonical repofinos/morphir-elm- These point to the canonical repositoryAdditional changes
.claude/skills/directory layoutmorphir-gotomorphirTest plan
just verify- All modules build successfullyjust test- All tests passCloses: morphir-d3g
🤖 Generated with Claude Code