Claude/complete small todo eln4m #324
Open
+27
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update() method was replacing position quantities instead of aggregating them when receiving WebSocket updates. This caused multiple trades for the same security to show as separate entries instead of a single net position. Changed the logic to add the incoming quantity to the existing quantity rather than replacing it. Co-Authored-By: genes.victor@gmail.com <genes.victor@gmail.com>
Angular fix:
- Fixed row-id mismatch: getRowNode() now uses 'Position-{security}' format
to match getRowId() return value
- Removed incorrect quantity aggregation (WebSocket sends absolute totals)
React fix:
- Fixed position update logic to find and update existing positions
instead of always appending new rows
- Positions are now properly updated by security symbol
Co-Authored-By: genes.victor@gmail.com <genes.victor@gmail.com>
…gation Fix real-time position aggregation in Angular and React frontends
…ment variable - Updated Program.cs to read PEOPLE_SERVICE_PORT env var (defaults to 18089) - Updated launchSettings.json to use the environment variable - Updated README.md to document the configuration option and remove TODO
✅ Deploy Preview for lucky-concha-f3599f canceled.
|
|
One or more co-authors of this pull request were not found. You must specify co-authors in commit message trailer via: Supported
Please update your commit message(s) by doing |
psmulovics
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.