Conversation
Enhanced Dashboard so users can now specify start & End date and frequency the wish to see data for. The added several new charts to provide a better visualation.
sulamana
changed the title
|
here is a preview of the changes 
|
kamransaleem
changed the title
There was a problem hiding this comment.
Reorganise this file so that the paths are together and the routes are together, a bit jumbled atm
There was a problem hiding this comment.
Reorganise this file so that the paths are together and the routes are together, a bit jumbled atm
There was a problem hiding this comment.
Parsing and parameter validation should be done at the endpoint. The DAO should not do this, but instead be provided valid, typed parameters
There was a problem hiding this comment.
Parsing and parameter validation should be done at the endpoint. The DAO should not do this, but instead be provided valid, typed parameters
| }; | ||
|
|
||
| ListRoute<AccessLogSummary> findUsersSummaryRoute = (request, response) -> { | ||
| String frequency = request.params("frequency"); // year, day, week, month |
There was a problem hiding this comment.
should frequency be a ENUM and named Period or perhaps consider the existing Waltz enum called Duration in org,finos,waltz.model?
refer to EntityStatisticEndpoint for it's usage
There was a problem hiding this comment.
some of the fields of this class are better represented with existing java classes, i.e. Period.
| import OperationTrendsChart from "./OperationTrendsChart.svelte"; | ||
| import AccessLogOperationTrendsChart from "./AccessLogOperationTrendsChart.svelte"; | ||
|
|
||
| const FREQUENCY_OPTIONS = [ |
There was a problem hiding this comment.
define as an enum if not already existing, these live in common/services/enums
| ]; | ||
|
|
||
| let selectedFrequency = "month"; | ||
| let startDate = new Date(new Date().setMonth(new Date().getMonth() - 6)).toISOString().split('T')[0]; |
There was a problem hiding this comment.
use moment.js for this, don't rely on string parsing,
| return accessLogDao.findMonthOnMonthUsers(mode, currentYear); | ||
| } | ||
|
|
||
| public List<AccessLogSummary> findAccessLogSummary(String freq, String startDate, String endDate){ |
There was a problem hiding this comment.
validation? perhaps endDate > startDate?
Should be using typed parameters here, not strings
| refreshing = false; | ||
| }}> | ||
| {#if refreshing} | ||
| 🔄 Refreshing... |
There was a problem hiding this comment.
use the existing loading notiication i.e.
<waltz-loading-notification show="$ctrl.visibility.loading"
style="padding-top: 54px;"
name="Loading">
</waltz-loading-notification>
2 participants
Enhanced Dashboard so users can now specify start & End date and frequency the wish to see data for.
The added several new charts to provide a better visualation.