#7460 Boingy Graph: doesn't render colours if the ratings differ from…#7461
Merged
kamransaleem merged 1 commit intofinos:masterfrom Mar 2, 2026
Merged
Conversation
… from hardcoded values (pickWorst) - use instead the values returned from the database which can be user defined. Fallback to original default values remains.
kamransaleem
requested review from
a team,
davidwatkins73,
jain-shreyans-db,
mayank-d-gupta-db and
meenakshi-saraf-db
Member
davidwatkins73
left a comment
davidwatkins73
left a comment
There was a problem hiding this comment.
Looks great to me, good catch!
davidwatkins73
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… hardcoded values (pickWorst)
See below with the working result.