fb: address fb on nesting dependency groups #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
citelao
commented
May 5, 2025
| ("quux", "child_1"), | ||
| ("quux", "child_2"), | ||
| ("quux", "root"), | ||
| ("quux", "root"), # TODO: is this expected? |
Author
There was a problem hiding this comment.
Note that here and below we have duplicate packages in the all_requires list. Unsure if this is desired.
radoering
force-pushed
the
nested-dependency-groups
branch
from
c6ff173 to
c01b640
Compare
citelao
force-pushed
the
nested-dependency-groups-fb
branch
from
cb00a96 to
a63171d
Compare
radoering
force-pushed
the
nested-dependency-groups
branch
from
849a7f4 to
4a8a8ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, there is some open feedback on python-poetry#837. This change addresses a lot of it, e.g. rewriting the cycle-detection algorithm & the name-deduping algorithm.
What changed?
How tested?