Open
Conversation
…into feature/README � Conflicts: � build.gradle � src/main/java/com/makefire/anonymous/config/swagger/SwaggerConfig.java � src/main/java/com/makefire/anonymous/config/web/advice/Advice.java � src/main/resources/application.yml
|
👋 Thanks for PR! Please regist comment with command: |
choipureum
reviewed
Feb 25, 2022
src/main/java/com/makefire/anonymous/domain/board/entity/Board.java
Outdated
Show resolved
Hide resolved
choipureum
reviewed
Feb 25, 2022
src/main/java/com/makefire/anonymous/rest/controller/api/BoardController.java
Outdated
Show resolved
Hide resolved
choipureum
reviewed
Feb 25, 2022
src/main/java/com/makefire/anonymous/rest/dto/response/board/BoardResponseDTO.java
Outdated
Show resolved
Hide resolved
Closed
2 tasks
choipureum
added
enhancement
choipureum
reviewed
Feb 27, 2022
src/main/java/com/makefire/anonymous/rest/controller/api/BoardController.java
Outdated
Show resolved
Hide resolved
…/Board_CRUD # Conflicts: # README.md # src/main/java/com/makefire/anonymous/domain/board/entity/Board.java # src/main/java/com/makefire/anonymous/domain/board/repository/BoardRepository.java # src/main/java/com/makefire/anonymous/domain/common/BasicEntity.java # src/main/java/com/makefire/anonymous/rest/controller/api/BoardController.java # src/main/java/com/makefire/anonymous/rest/dto/response/Response.java # src/main/java/com/makefire/anonymous/service/board/BoardService.java
choipureum
reviewed
Mar 4, 2022
|
|
||
| @Service | ||
| @AllArgsConstructor | ||
| @Transactional |
Collaborator
There was a problem hiding this comment.
@Transactional을 클래스 레벨에서 다루기보다 메소드 단위로 다루는게 좋아보입니다.
added 2 commits
March 7, 2022 09:43
choipureum
reviewed
Mar 7, 2022
| public static List<BoardResponse> fromList(List<Board> boardList) { | ||
| List<BoardResponse> boardResponseList = new ArrayList<>(); | ||
| for (Board board : boardList | ||
| ) { |
choipureum
reviewed
Mar 11, 2022
| return response(boardService.updateBoard(boardRequest)); | ||
| } | ||
|
|
||
| @DeleteMapping("{id}") |
choipureum
reviewed
Mar 25, 2022
| @@ -61,10 +65,14 @@ void selectBoardsTest() throws Exception { | |||
| @DisplayName("게시판 단건 조회 테스트") | |||
| void selectBoardTest() throws Exception{ | |||
Collaborator
There was a problem hiding this comment.
throws Exception제거 및 예외케이스를 따로 만들어주세욤
Collaborator
|
훔 기존꺼랑 나는거라 흠... 연습 됬으면 ㄹㅇ 서비스 ㄱ ㄱ |
Jiwon-cho
commented
Apr 5, 2022
| * 가독성이나 유연성등의 측면에서 더 좋다는 | ||
| * 자료를 봐서 일단 적용해봄 | ||
| * 어떤게 더 날지 판단 부탁 | ||
| */ |
Author
There was a problem hiding this comment.
@choipureum 질문 이건데 확인좀 부탁하고, 다한것 같기는 한데.. 부족한거 있으면 말 해주면 감사
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.