feat(firebase_ui_auth): Use icon from OAuth provider as a fallback in ProfileScreen#451
feat(firebase_ui_auth): Use icon from OAuth provider as a fallback in ProfileScreen#451Rexios80 wants to merge 2 commits intofirebase:mainfrom
Conversation
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
@russellwheatley any thoughts? |
|
@Rexios80 - I don't have a problem with it, but I guess I'm not keen on additional dependencies. Is there any way around the addition of flutter_svg? |
|
|
|
@russellwheatley thoughts on how to proceed here? |
|
@Rexios80 - I think I would prefer to use the method on the oauth provider if possible |
|
Closing in favor of #474 |
Description
In the
ProfileScreen, use the OAuth provider icon as a fallback if availableRelated Issues
#383
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.melos run test:unit:alldoesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?