Skip to content

test: fix View UI tests that require more time for sign-in to occur #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+35 −9
Open

test: fix View UI tests that require more time for sign-in to occur #1263

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
21e21b0
test: fix View UI tests that are still signing in at the point of fai…
russellwheatley May 30, 2025
e33f963
test: revert to using waitForExistence() with longer timeout
russellwheatley Jun 2, 2025
79a47f1
test: update to use Swift .wait() method
russellwheatley Jun 2, 2025
442a358
test: refactor wait for signed-in View
russellwheatley Jun 2, 2025
2eaa752
test: need to wrap in DispatchQueue
russellwheatley Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions .../FirebaseSwiftUIExample/FirebaseSwiftUIExampleUITests/FirebaseSwiftUIExampleUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,16 @@ final class FirebaseSwiftUIExampleUITests: XCTestCase {
signInButton.tap()

let signedInText = app.staticTexts["signed-in-text"]
XCTAssertTrue(
signedInText.waitForExistence(timeout: 10),
"SignedInView should be visible after login"
)
let maxWaitTime: TimeInterval = 30
let interval: TimeInterval = 1
var waited: TimeInterval = 0

while !signedInText.exists && waited < maxWaitTime {
sleep(UInt32(interval))
waited += interval
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use waitForExpectations instead.


XCTAssertTrue(signedInText.exists, "SignedInView should be visible after login")

dismissAlert(app: app)
// Check the Views are updated
Expand Down Expand Up @@ -177,9 +183,15 @@ final class FirebaseSwiftUIExampleUITests: XCTestCase {
signInButton.tap()

let signedInText = app.staticTexts["signed-in-text"]
XCTAssertTrue(
signedInText.waitForExistence(timeout: 20),
"SignedInView should be visible after login"
)
let maxWaitTime: TimeInterval = 30
let interval: TimeInterval = 1
var waited: TimeInterval = 0

while !signedInText.exists && waited < maxWaitTime {
sleep(UInt32(interval))
waited += interval
}

XCTAssertTrue(signedInText.exists, "SignedInView should be visible after login")
}
}