refactor: move providers to new protocols and refactor API in light of API document #1272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
russellwheatley
commented
Oct 2, 2025
russellwheatley
commented
- implement AuthProviderSwift & AuthProviderUI & refactored providers to use these protocols.
- Update Facebook, Google and Phone auth implementation to conform to new protocols.
- Rename APIs in light of agreed API document.
- Refactored authentication methods to return SignInOutcome enum.
- Implement methods for updating user profile.
Lyokone
reviewed
Oct 6, 2025
| public typealias VerificationID = String | ||
|
|
||
| public class PhoneAuthProviderAuthUI: @preconcurrency PhoneAuthProviderAuthUIProtocol { | ||
| public class PhoneAuthProviderAuthUI: @preconcurrency PhoneAuthProviderAuthUIProtocol, AuthProviderUI { |
There was a problem hiding this comment.
We could probably try to remove the @preconcurrency and address concurrency properly here
There was a problem hiding this comment.
removed preconcurrency 👍
Lyokone
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.