Skip to content

fix: allow user to pass in a closure for custom action on email link and phone auth buttons #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

fix: allow user to pass in a closure for custom action on email link and phone auth buttons #1306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03ec0a1
fix: allow user to pass in a closure
russellwheatley Nov 10, 2025
945bf05
Merge branch 'development' into fix-closure
russellwheatley Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Services/AuthService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public final class AuthService {
private var listenerManager: AuthListenerManager?

var emailSignInEnabled = false
private var emailSignInCallback: (@MainActor () -> Void)?
private var emailSignInCallback: (() -> Void)?

private var providers: [AuthProviderUI] = []

Expand Down Expand Up @@ -324,7 +324,7 @@ public extension AuthService {
}

/// Enable email sign-in with custom callback
func withEmailSignIn(onTap: @escaping @MainActor () -> Void) -> AuthService {
func withEmailSignIn(onTap: @escaping () -> Void) -> AuthService {
emailSignInEnabled = true
emailSignInCallback = onTap
return self
Expand Down
2 changes: 1 addition & 1 deletion FirebaseSwiftUI/FirebasePhoneAuthSwiftUI/Sources/Services/AuthService+Phone.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public extension AuthService {

/// Register phone sign-in with custom behavior
@discardableResult
func withPhoneSignIn(onTap: @escaping @MainActor () -> Void) -> AuthService {
func withPhoneSignIn(onTap: @escaping () -> Void) -> AuthService {
registerProvider(providerWithButton: PhoneAuthProviderAuthUI(onTap: onTap))
return self
}
Expand Down
9 changes: 6 additions & 3 deletions FirebaseSwiftUI/FirebasePhoneAuthSwiftUI/Sources/Services/PhoneAuthProviderAuthUI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,17 @@ public class PhoneAuthProviderAuthUI: AuthProviderUI {
public let id: String = "phone"

// Callback for when the phone auth button is tapped
private let onTap: @MainActor () -> Void
private let onTap: () -> Void

public init(onTap: @escaping @MainActor () -> Void) {
public init(onTap: @escaping () -> Void) {
typedProvider = PhoneProviderSwift()
self.onTap = onTap
}

@MainActor public func authButton() -> AnyView {
AnyView(PhoneAuthButtonView(onTap: onTap))
let mainActorClosure: @MainActor () -> Void = {
self.onTap()
}
return AnyView(PhoneAuthButtonView(onTap: mainActorClosure))
}
}