Skip to content

fix: update password title & provide instructions to verify email #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 12, 2025
Merged

fix: update password title & provide instructions to verify email #1308

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fdaeb97
fix: update password title
russellwheatley Nov 12, 2025
f424606
chore: include message for user to follow
russellwheatley Nov 12, 2025
ee47710
chore: local strings
russellwheatley Nov 12, 2025
b848689
chore: remove stale comment
russellwheatley Nov 12, 2025
bf99d15
chore: revert state
russellwheatley Nov 12, 2025
7440d4e
fix: move to alert
russellwheatley Nov 12, 2025
c9a1f55
format
russellwheatley Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Strings/Localizable.xcstrings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3053,6 +3053,10 @@
}
}
},
"Please tap on the link in your email to complete verification." : {
"comment" : "A message displayed in a sheet that appears after a user requests email verification. It instructs the user to tap on the link in their email to complete the verification process.",
"isCommentAutoGenerated" : true
},
"PrivacyPolicy" : {
"comment" : "Text linked to a web page with the Privacy Policy content.",
"extractionState" : "manual",
Expand Down Expand Up @@ -4963,5 +4967,5 @@

}
},
"version" : "1.0"
"version" : "1.1"
}
7 changes: 7 additions & 0 deletions FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Utils/StringUtils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,13 @@ public class StringUtils {
return localizedString(for: "EnterYourPassword")
}

/// Update password title
/// found in:
/// - UpdatePasswordView
public var updatePasswordTitle: String {
return localizedString(for: "UpdatePasswordTitle")
}

/// Password recovery title
/// found in:
/// - PasswordRecoveryView
Expand Down
1 change: 0 additions & 1 deletion FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/MFAManagementView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ extension MFAManagementView: View {
.onAppear {
loadEnrolledFactors()
}
// Password prompt sheet now centralized in AuthPickerView
}

@ViewBuilder
Expand Down
2 changes: 1 addition & 1 deletion FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/SignedInView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,11 @@ extension SignedInView: View {
)
.presentationDetents([.medium])
}
// Password prompt sheet now centralized in AuthPickerView
.sheet(isPresented: $showEmailVerificationSent) {
Copy link
Member

@demolaf demolaf Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should use .alert instead for better UX

Copy link
Member Author

@russellwheatley russellwheatley Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks better than alert, no?
Image

Copy link
Member

@demolaf demolaf Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, there's a title, brief message and single action. Either the sheet's height is reduced or a container like .alert if not just looks odd.

Copy link
Member Author

@russellwheatley russellwheatley Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I've changed it to alert.

VStack(spacing: 24) {
Text(authService.string.verifyEmailSheetMessage)
.font(.headline)
Text("Please tap on the link in your email to complete verification.")
Button {
showEmailVerificationSent = false
} label: {
Expand Down
2 changes: 1 addition & 1 deletion FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/UpdatePasswordView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ extension UpdatePasswordView: View {
}
.frame(maxWidth: .infinity, maxHeight: .infinity, alignment: .top)
.safeAreaPadding()
.navigationTitle(authService.string.passwordRecoveryTitle)
.navigationTitle(authService.string.updatePasswordTitle)
.alert(
"Password Updated",
isPresented: $showAlert
Expand Down
Loading