Skip to content

Conversation

HannahShiSFB
Copy link
Collaborator

@HannahShiSFB HannahShiSFB commented Nov 1, 2024

Abseil-cpp source snapshot from release tag 20240722.0

Removed all test and benchmark files:

rm -rf `find absl/ -name "*_test.cc"`
rm -rf `find absl/ -name "*_benchmark.cc"`
rm absl/status/internal/status_matchers.*
rm -rf absl/time/internal/cctz/testdata
rm -rf `find absl/ -name "BUILD.bazel"`
rm -rf `find absl/ -name "CMakeLists.txt"`
rm -rf absl/copts

For gRPC dependency starting form 1.68.x grpc/grpc#37543

@HannahShiSFB
Copy link
Collaborator Author

CC: @paulb777 @sampajano

@paulb777 paulb777 closed this Nov 7, 2024
@paulb777 paulb777 reopened this Nov 7, 2024
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it feasible to remove the files necessary to fix the 600+ build warnings? https://github.com/firebase/abseil-cpp-SwiftPM/actions/runs/11714366860/job/32628923274#step:6:817

@HannahShiSFB
Copy link
Collaborator Author

Majority of them are timezon data, which I don't know whether it's safe to remove them.
There are also some inc files cannot be removed.
I can remove the bazel and cmake build files.

@paulb777
Copy link
Member

paulb777 commented Nov 7, 2024

If SPM isn't finding the timezone data, they're not being built. If they're needed, they should be included in a resources specification in the Package.swift.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

Is it ready to merge and tag?

@HannahShiSFB
Copy link
Collaborator Author

HannahShiSFB commented Nov 8, 2024

Yes, please go ahead, thanks.

@paulb777 paulb777 merged commit e0d017d into firebase:main Nov 8, 2024
2 checks passed
@paulb777
Copy link
Member

paulb777 commented Nov 8, 2024

Merged, tagged, and created a GitHub release - https://github.com/firebase/abseil-cpp-SwiftPM/releases/tag/0.20240722.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants