-
Notifications
You must be signed in to change notification settings - Fork 13
Upgrade to abseil-cpp 20240722.0 #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CC: @paulb777 @sampajano |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it feasible to remove the files necessary to fix the 600+ build warnings? https://github.com/firebase/abseil-cpp-SwiftPM/actions/runs/11714366860/job/32628923274#step:6:817
Majority of them are timezon data, which I don't know whether it's safe to remove them. |
If SPM isn't finding the timezone data, they're not being built. If they're needed, they should be included in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Is it ready to merge and tag?
Yes, please go ahead, thanks. |
Merged, tagged, and created a GitHub release - https://github.com/firebase/abseil-cpp-SwiftPM/releases/tag/0.20240722.0 |
Abseil-cpp source snapshot from release tag 20240722.0
Removed all test and benchmark files:
For gRPC dependency starting form 1.68.x grpc/grpc#37543