Feat: Introduce specific error codes for DataConnectOperationError #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enhances error handling for DataConnect operations by introducing specific error codes within `DataConnectOperationError`. Key changes: - Added `DataConnectOperationError.Code` enum with `uniqueConstraintFailed` and `genericOperationError` cases. - `DataConnectOperationError` now stores and exposes an instance of this code. - Updated `GrpcClient` to throw `DataConnectOperationError` with the `.uniqueConstraintFailed` code when a unique constraint violation is detected during a mutation and the backend error message contains relevant keywords. - Other operational failures resulting in `DataConnectOperationError` will use the `.genericOperationError` code. This provides developers with a more granular way to identify and handle specific operation failures, particularly unique constraint violations. (Note: Unit test file was removed as per user request.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enhances error handling for DataConnect operations by introducing specific error codes within
DataConnectOperationError.Key changes:
DataConnectOperationError.Codeenum withuniqueConstraintFailedandgenericOperationErrorcases.DataConnectOperationErrornow stores and exposes an instance of this code.GrpcClientto throwDataConnectOperationErrorwith the.uniqueConstraintFailedcode when a unique constraint violation is detected during a mutation and the backend error message contains relevant keywords.DataConnectOperationErrorwill use the.genericOperationErrorcode.This provides developers with a more granular way to identify and handle specific operation failures, particularly unique constraint violations.
(Note: Unit test file was removed as per user request.)