fix(auth): use base64url encoding for JWT segments in createCustomToken#167
Closed
JaredEzz wants to merge 1 commit intofirebase:nextfrom
Closed
fix(auth): use base64url encoding for JWT segments in createCustomToken#167JaredEzz wants to merge 1 commit intofirebase:nextfrom
JaredEzz wants to merge 1 commit intofirebase:nextfrom
Conversation
The _encodeSegment method was using base64Encode (standard base64 with + and / characters) instead of base64Url.encode (base64url with - and _ characters). Per RFC 7515, JWT segments must be base64url-encoded without padding. This caused Firebase Auth to reject custom tokens with the error "invalid-custom-token" because the signature was not correctly encoded. Fixes firebase#16 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16
createCustomTokenproduces JWTs that Firebase Auth rejects withinvalid-custom-tokenbecause the token segments are encoded with standard base64 instead of base64url._encodeSegmentintoken_generator.dartusedbase64Encode(standard base64, which uses+and/characters) instead ofbase64Url.encode(base64url, which uses-and_characters per RFC 4648 Section 5).base64Encode(buffer).replaceFirst(RegExp(r'=+$'), '')withbase64Url.encode(buffer).replaceAll('=', '').Note: The app_check
token_generator.dartalready handles this correctly via its_toWebSafeBase64helper -- this PR brings the auth token generator in line with that approach using Dart's built-inbase64Urlcodec.This is a minimal one-line change. No new dependencies are introduced.
Related
createCustomTokenproduces tokens rejected by Firebase AuthTest plan
createCustomTokenoutput passes jwt.io validation without base64url warningssignInWithCustomTokensucceeds on a Flutter client using the generated token