-
Notifications
You must be signed in to change notification settings - Fork 271
Add GetQuotaFailure to the public API #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @justinattw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the error handling capabilities of the Firebase Admin Go SDK, particularly for Firebase Cloud Messaging. It introduces a new public API to programmatically access detailed quota failure information, which is crucial for applications dealing with rate limits. Concurrently, it undertakes a substantial refactoring effort by moving common error types and utilities to a dedicated Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant and beneficial refactoring of the error handling mechanism by exposing error-related types and functions in a new public errorutils package. This makes the error handling more transparent and idiomatic for users of the SDK. The core change of replacing the internal String field with a public Message field in FirebaseError is consistently applied across the codebase.
Additionally, this PR adds a new public API, GetQuotaFailure, to the messaging package, which allows developers to inspect detailed quota failure information from FCM. The related error handling logic has been cleanly refactored into a new messaging_errors.go file.
The changes are well-implemented and include comprehensive tests. I have a couple of suggestions to further improve the ergonomics and maintainability of the new additions.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
NOTE: This PR is based on #737
For now, I've opened a PR in justinattw#1 that reviews the change into the dependent PR.
Changes
Based on (and requires first merging of) #737
Closes #736
https://firebase.google.com/docs/reference/fcm/rest/v1/ErrorCode specifies that
google.rpc.QuotaFailureis returned with FCM.We expose this via the new public API
GetQuotaFailure(err *errorutils.FirebaseError) *QuotaFailuremethod.I also refactored the
messaging.goerror-related code bits intomessaging_errors.go.