Skip to content

chore: Update tests for getting and deleting provider uid via phone number and email. #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025
Merged

chore: Update tests for getting and deleting provider uid via phone number and email. #1068

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
455c241
chore: Update tests for getting and deleting provider uid via phone n…
jonathanedey Jan 28, 2025
4f3c56d
Merge branch 'master' into je-string-comp
jonathanedey Jan 28, 2025
982d1d6
Merge branch 'master' into je-string-comp
jonathanedey Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/test/java/com/google/firebase/auth/FirebaseUserManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,19 +402,23 @@ public void testGetUserByProviderUidWithPhone() throws Exception {
TestResponseInterceptor interceptor = initializeAppForUserManagement(
TestUtils.loadResource("getUser.json"));
UserRecord userRecord = FirebaseAuth.getInstance()
.getUserByProviderUidAsync("phone", "+1234567890").get();
.getUserByProviderUidAsync(new String("phone"), "+1234567890").get();
checkUserRecord(userRecord);
checkRequestHeaders(interceptor);
GenericJson parsed = parseRequestContent(interceptor);
assertEquals(ImmutableList.of("+1234567890"), parsed.get("phoneNumber"));
}

@Test
public void testGetUserByProviderUidWithEmail() throws Exception {
TestResponseInterceptor interceptor = initializeAppForUserManagement(
TestUtils.loadResource("getUser.json"));
UserRecord userRecord = FirebaseAuth.getInstance()
.getUserByProviderUidAsync("email", "[email protected]").get();
.getUserByProviderUidAsync(new String("email"), "[email protected]").get();
checkUserRecord(userRecord);
checkRequestHeaders(interceptor);
GenericJson parsed = parseRequestContent(interceptor);
assertEquals(ImmutableList.of("[email protected]"), parsed.get("email"));
}

@Test
Expand Down Expand Up @@ -1248,20 +1252,22 @@ public void testDeleteProviderAndPhone() {

@Test
public void testDoubleDeletePhoneProvider() throws Exception {
String providerId = new String("phone");
UserRecord.UpdateRequest update = new UserRecord.UpdateRequest("uid")
.setPhoneNumber(null);

try {
update.setProvidersToUnlink(ImmutableList.of("phone"));
update.setProvidersToUnlink(ImmutableList.of(providerId));
fail("No error thrown for double delete phone provider");
} catch (IllegalArgumentException expected) {
}
}

@Test
public void testDoubleDeletePhoneProviderReverseOrder() throws Exception {
String providerId = new String("phone");
UserRecord.UpdateRequest update = new UserRecord.UpdateRequest("uid")
.setProvidersToUnlink(ImmutableList.of("phone"));
.setProvidersToUnlink(ImmutableList.of(providerId));

try {
update.setPhoneNumber(null);
Expand Down