Implementation for Fetching and Caching Server Side Remote Config #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
requested changes
Jun 20, 2025
src/main/java/com/google/firebase/remoteconfig/AndCondition.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigClient.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/firebase/remoteconfig/MockRemoteConfigClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/firebase/remoteconfig/ServerTemplateImpl.java
Outdated
Show resolved
Hide resolved
added 10 commits
June 23, 2025 11:08
lahirumaramba
approved these changes
Jun 23, 2025
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
LGTM! Please get a TW review on the reference docs. Thank you!
rathovarun1032
added a commit
that referenced
this pull request
Sep 23, 2025
* Implementation for Fetching and Caching Server Side Remote Config (#1107)009 * Implementation for Fetching and Caching Server Side Remote Config * implementation of fetch , cache and load of template --------- Co-authored-by: Varun Rathore <[email protected]> * Implement custom signal targeting for server side RC (#1108) Co-authored-by: Athira M <[email protected]> * Implement percent evaluation for server side RC (#1114) * [feat] Implement percent evaluation for server side RC * Ssrc bugbash fix (#1117) * Handle empty context * fix issue related to update time * fix string equality * fix textcase * Fix lint errors * Add unit tests * fix for [438426692](getDouble() logs a malformed warning on type conversion failure) Using getDouble on a string parameter value, returns the appropriate default static value but logs a warning which looks incorrect ("%s" in the warning message?). * Update ServerTemplateResponse.java to fix b/438607881 In the server template builder flow using cached template, evaluation using custom signals is not working as intended. * Update getServerRemoteConfig.json to fix b/438607881 * Update getServerTemplateData.json to fix b/438607881 * fix for bugs * Resolve comment related to revert of ServerVersion Class * remove serverVersion * Resolve comments related to Evaluator * fix indentation * fix indentation * fix indentations * fix multi line indent * fix multi line indents * Update ConditionEvaluator.java * Update ConditionEvaluator.java --------- Co-authored-by: Athira M <[email protected]> Co-authored-by: Varun Rathore <[email protected]> * Create ParameterValueTest.java * Fix typo errors * Change return type and cache regex * Addressed comment to make cache atomic * Trigger CI --------- Co-authored-by: Varun Rathore <[email protected]> Co-authored-by: Athira M <[email protected]> Co-authored-by: Athira M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
This PR contain implementation change of fetch , catching of server template along with skeleton of converting template into ServerTemplateResponse which will be used for evaluation. Evaluate logic will be covered in followup PR.
ref doc: http://shortn/_dXWXGNCXyJ