Using Array.isArray() instead of instanceof (#237)

Author: hiranya911

.gitignore

@@ -1,4 +1,5 @@
 .idea
+.vscode
 .DS_Store
 npm-debug.log
 

package-lock.json

@@ -250,12 +250,7 @@ export class FirebaseTokenGenerator {
     if (typeof developerClaims === 'undefined') {
       return true;
     }
-
-    if (typeof developerClaims === 'object' && developerClaims !== null && !(developerClaims instanceof Array)) {
-      return true;
-    }
-
-    return false;
+    return validator.isNonNullObject(developerClaims);
   }
 
 

src/auth/token-generator.ts

@@ -33,7 +33,7 @@ export function isBuffer(value: any): boolean {
  * @return {boolean} Whether the value is an array or not.
  */
 export function isArray(value: any): boolean {
-  return value instanceof Array;
+  return Array.isArray(value);
 }
 
 /**
@@ -98,7 +98,7 @@ export function isNonEmptyString(value: any): boolean {
  * @return {boolean} Whether the value is an object or not.
  */
 export function isObject(value: any): boolean {
-  return typeof value === 'object' && !(value instanceof Array);
+  return typeof value === 'object' && !isArray(value);
 }