-
Notifications
You must be signed in to change notification settings - Fork 409
feat: add basic fpnv #3030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
boikoa-gl
wants to merge
7
commits into
firebase:fpnv
Choose a base branch
from
boikoa-gl:fpnv
base: fpnv
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add basic fpnv #3030
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f603e65
feat: add basic fpnv
boikoa-gl 23868e8
chore: resolve comments
boikoa-gl 7f71eed
fix: remove unused interface
boikoa-gl 8413368
chore: update export
boikoa-gl e90c2bd
chore: linting
boikoa-gl 2a759df
chore: update export
boikoa-gl fabcf80
feat: add apidocs
boikoa-gl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { App } from '../app'; | ||
|
|
||
| import { | ||
| FirebasePhoneNumberTokenVerifier, | ||
| FpnvToken, | ||
| createFPNTVerifier, | ||
| } from './token-verifier'; | ||
|
|
||
|
|
||
| export abstract class BaseFpnv { | ||
boikoa-gl marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| protected readonly fPNTVerifier: FirebasePhoneNumberTokenVerifier; | ||
boikoa-gl marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| protected constructor( | ||
| app: App, | ||
| ) { | ||
| this.fPNTVerifier = createFPNTVerifier(app); | ||
| } | ||
|
|
||
|
|
||
| public async verifyToken(idToken: string): Promise<FpnvToken> { | ||
| return await this.fPNTVerifier.verifyJWT(idToken); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /*! | ||
| * Copyright 2021 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { App } from '../app'; | ||
|
|
||
| // Import all public types with aliases, and re-export from the auth namespace. | ||
|
|
||
| import { Fpnv as TFpnv } from './fpnv'; | ||
|
|
||
| import { | ||
| BaseFpnv as TBaseFpnv, | ||
| } from './base-fpnv'; | ||
|
|
||
| import { | ||
| FpnvToken as TFpnvToken, | ||
| } from './token-verifier'; | ||
|
|
||
|
|
||
| export declare function fpnv(app?: App): fpnv.Fpnv; | ||
|
|
||
| /* eslint-disable @typescript-eslint/no-namespace */ | ||
| export namespace fpnv { | ||
| export type BaseFpnv = TBaseFpnv; | ||
| export type Fpnv = TFpnv; | ||
| export type FpnvToken = TFpnvToken; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /*! | ||
| * @license | ||
| * Copyright 2017 Google LLC | ||
boikoa-gl marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { App } from '../app'; | ||
| import { BaseFpnv } from './base-fpnv'; | ||
|
|
||
| /** | ||
| * Fpnv service bound to the provided app. | ||
| */ | ||
| export class Fpnv extends BaseFpnv { | ||
boikoa-gl marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| private readonly app_: App; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: you can simplify this by using constructor parameter properties. constructor(readonly app: App) { ...
// this.app |
||
|
|
||
| constructor(app: App) { | ||
| super(app); | ||
|
|
||
| this.app_ = app; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the app associated with this Fpnv instance. | ||
| * | ||
| * @returns The app associated with this Fpnv instance. | ||
boikoa-gl marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| */ | ||
| get app(): App { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this used for anything? If not, we can probably remove this getter |
||
| return this.app_; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /*! | ||
| * Copyright 2020 Google LLC | ||
boikoa-gl marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /** | ||
| * Firebase Phone Number Verification. | ||
| * | ||
| * @packageDocumentation | ||
| */ | ||
|
|
||
| import { App, getApp } from '../app'; | ||
| import { FirebaseApp } from '../app/firebase-app'; | ||
| import { Fpnv } from './fpnv'; | ||
|
|
||
| /** | ||
| * Gets the {@link Fpnv} service for the default app or a | ||
| * given app. | ||
| * | ||
| * `getFirebasePnv()` can be called with no arguments to access the default app's | ||
| * {@link Fpnv} service or as `getFirebasePnv(app)` to access the | ||
| * {@link Fpnv} service associated with a specific app. | ||
| * | ||
| * @example | ||
| * ```javascript | ||
| * // Get the Fpnv service for the default app | ||
| * const defaultFpnv = getFirebasePnv(); | ||
| * ``` | ||
| * | ||
| * @example | ||
| * ```javascript | ||
| * // Get the Fpnv service for a given app | ||
| * const otherFpnv = getFirebasePnv(otherApp); | ||
| * ``` | ||
boikoa-gl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * | ||
| */ | ||
| export function getFirebasePnv(app?: App): Fpnv { | ||
| if (typeof app === 'undefined') { | ||
| app = getApp(); | ||
| } | ||
|
|
||
| const firebaseApp: FirebaseApp = app as FirebaseApp; | ||
| return firebaseApp.getOrInitService('fpnv', (app) => new Fpnv(app)); | ||
| } | ||
|
|
||
| export { | ||
| Fpnv, | ||
| } from './fpnv'; | ||
|
|
||
| export { | ||
| BaseFpnv, | ||
| } from './base-fpnv'; | ||
|
|
||
|
|
||
| export { | ||
| FpnvToken, | ||
| } from './token-verifier'; | ||
|
|
||
|
|
||
| export { | ||
| FirebasePnvError, | ||
| FpnvErrorCode, | ||
| } from '../utils/error'; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.