Skip to content

Commit ac6da09

Browse files
committed
Undo changes done by the formatter to the target releases
The release note generator does not need to generate MD that matches what the formatter would do. Also, modify the input CHANGELOG.md to match format we expect to have for `{:.external}` (no space)
1 parent cc0c6b5 commit ac6da09

File tree

2 files changed

+15
-19
lines changed

2 files changed

+15
-19
lines changed

plugins/src/test/resources/BasicProject/firebase-storage/CHANGELOG.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ Note: We did some super cool stuff here!
55
- [feature] Added support for disjunctions in queries (`OR` queries).
66

77
- [feature] Firebase now supports Kotlin coroutines. With this release, we added
8-
[`kotlinx-coroutines-play-services`](https://kotlinlang.org/api/kotlinx.coroutines/kotlinx-coroutines-play-services/){:
9-
.external} to `firebase-firestore-ktx` as a transitive dependency, which exposes the
8+
[`kotlinx-coroutines-play-services`](https://kotlinlang.org/api/kotlinx.coroutines/kotlinx-coroutines-play-services/){:.external} to `firebase-firestore-ktx` as a transitive dependency, which exposes the
109
`Task<T>.await()` suspend function to convert a
1110
[`Task`](https://developers.google.com/android/guides/tasks) into a Kotlin coroutine.
1211

@@ -15,7 +14,7 @@ Note: We did some super cool stuff here!
1514
- [removed] Removed some old stuff (#562)
1615

1716
- [feature] Added this thing we wanted
18-
[#444](//github.com/firebase/firebase-android-sdk/issues/number){: .external}
17+
[#444](//github.com/firebase/firebase-android-sdk/issues/number){:.external}
1918

2019
- [feature] Added
2120
[`Query.snapshots()`](/docs/reference/kotlin/com/google/firebase/firestore/ktx/package-summary#snapshots_1)
@@ -45,7 +44,7 @@ Note: We did some super cool stuff here!
4544
# 24.5.0
4645

4746
- [fixed] Fixed stack overflow caused by deeply nested server timestamps. (GitHub
48-
[#4702](//github.com/firebase/firebase-android-sdk/issues/4702){: .external})
47+
[#4702](//github.com/firebase/firebase-android-sdk/issues/4702){:.external})
4948

5049
## Kotlin
5150

plugins/src/test/resources/MakeReleaseNotes/release-notes.md

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,32 +2,29 @@
22

33
Note: We did some super cool stuff here!
44

5-
- {{feature}} Added support for disjunctions in queries (`OR` queries).
5+
* {{feature}} Added support for disjunctions in queries (`OR` queries).
66

7-
- {{feature}} Firebase now supports Kotlin coroutines. With this release, we added
8-
[`kotlinx-coroutines-play-services`](https://kotlinlang.org/api/kotlinx.coroutines/kotlinx-coroutines-play-services/){:
9-
.external} to `firebase-firestore-ktx` as a transitive dependency, which exposes the
7+
* {{feature}} Firebase now supports Kotlin coroutines. With this release, we added
8+
[`kotlinx-coroutines-play-services`](https://kotlinlang.org/api/kotlinx.coroutines/kotlinx-coroutines-play-services/){:.external} to `firebase-firestore-ktx` as a transitive dependency, which exposes the
109
`Task<T>.await()` suspend function to convert a
1110
[`Task`](https://developers.google.com/android/guides/tasks) into a Kotlin coroutine.
1211

13-
- {{fixed}} An issue on GitHub [#123](//github.com/firebase/firebase-android-sdk/issues/123){:
14-
.external}
12+
* {{fixed}} An issue on GitHub [#123](//github.com/firebase/firebase-android-sdk/issues/123){: .external}
1513

16-
- {{removed}} Removed some old stuff GitHub
17-
[#562](//github.com/firebase/firebase-android-sdk/issues/562){: .external}
14+
* {{removed}} Removed some old stuff GitHub [#562](//github.com/firebase/firebase-android-sdk/issues/562){: .external}
1815

19-
- {{feature}} Added this thing we wanted GitHub
20-
[#444](//github.com/firebase/firebase-android-sdk/issues/444){: .external}
16+
* {{feature}} Added this thing we wanted
17+
GitHub [#444](//github.com/firebase/firebase-android-sdk/issues/444){: .external}
2118

22-
- {{feature}} Added
19+
* {{feature}} Added
2320
[`Query.snapshots()`](/docs/reference/kotlin/com/google/firebase/firestore/ktx/package-summary#snapshots_1)
2421
and
2522
[`DocumentReference.snapshots()`](/docs/reference/kotlin/com/google/firebase/firestore/ktx/package-summary#snapshots)
2623
Kotlin Flows to listen for realtime updates.
2724

28-
- {{fixed}} Fixed an issue in `waitForPendingWrites()` that could lead to a `NullPointerException`.
25+
* {{fixed}} Fixed an issue in `waitForPendingWrites()` that could lead to a `NullPointerException`.
2926

30-
- {{feature}} Added
27+
* {{feature}} Added
3128
[`Query.whereNotIn()`](</docs/reference/android/com/google/firebase/firestore/Query#whereNotIn(java.lang.String,%20java.util.List<?%20extends%20java.lang.Object)>>)
3229
and
3330
[`Query.whereNotEqualTo()`](</docs/reference/android/com/google/firebase/firestore/Query#whereNotEqualTo(java.lang.String,%20java.lang.Object)>)
@@ -40,6 +37,6 @@ Note: We did some super cool stuff here!
4037

4138
Neither query operator finds documents where the specified field isn't present.
4239

43-
- {{unchanged}} Idk ig we did some stuff
40+
* {{unchanged}} Idk ig we did some stuff
4441

45-
- {{removed}} some stuff that we didn't really like got removed
42+
* {{removed}} some stuff that we didn't really like got removed

0 commit comments

Comments
 (0)