Fix 4.27 protolite issue #5999
Closed
Fix 4.27 protolite issue #5999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesThe following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from. Changelogsprotolite-well-known-types |
Coverage Report 1Affected Products
Test Logs |
rlazo
approved these changes
May 30, 2024
|
Hi guys, any update on this fix ? |
|
We've decided to stick with the @binishmatheww if you have a particular use case that's blocked by the version update, please update #5997 to keep the conversation centralized. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/343215762,
This removes all the duplicated classes that protolite now implements (that we were previously providing ourselves as a work-around). This should fix existing compile issues with
4.27.0+, but it's not something we're necessarily ready to officially support yet.I've created b/343482773 (and left a note in the source linking to it) to track a future effort regarding an actual migration to support
4.27.0+.I've also translated all the remaining project level deps for well known types to be pinned deps on the existing
18.0.0release- since this will otherwise break existing libraries. I've avoided adding changelog entries for these libraries though, as this is technically a no-op change.fixes issues #5997