update targetSDK to 34 #6150

davidmotson · 2024-08-01T22:39:14Z

No description provided.

github-actions · 2024-08-01T22:39:29Z

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

google-oss-bot · 2024-08-01T22:40:06Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

github-actions · 2024-08-01T22:53:50Z

Unit Test Results

  862 files +  858   862 suites +858 27m 20s ⏱️ + 27m 17s
4 629 tests +4 579 4 598 ✔️ +4 548 21 💤 +21 10 ❌ +10
9 327 runs +9 227 9 275 ✔️ +9 175 42 💤 +42 10 ❌ +10

For more details on these failures, see this check.

Results for commit 298a4c9. ± Comparison against base commit 0605925.

google-oss-bot · 2024-08-01T22:58:47Z

Size Report ¹

Affected Products

base
Type Base (0605925) Merge (7502734) Diff
apk (release) 9.77 kB 9.77 kB +4 B (+0.0%)
firebase-annotations
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 8.80 kB 8.80 kB +4 B (+0.0%)
apk (release) 12.0 kB 12.0 kB +4 B (+0.0%)
firebase-appcheck-debug
Type Base (0605925) Merge (7502734) Diff
apk (release) 4.89 MB 4.89 MB +4 B (+0.0%)
firebase-appcheck-debug-testing
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 421 kB 421 kB +4 B (+0.0%)
firebase-appcheck-interop
Type Base (0605925) Merge (7502734) Diff
apk (release) 1.84 MB 1.84 MB +4 B (+0.0%)
firebase-appdistribution
Type Base (0605925) Merge (7502734) Diff
apk (release) 7.01 MB 7.01 MB +4 B (+0.0%)
firebase-common
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 140 kB 140 kB +4 B (+0.0%)
firebase-components
Type Base (0605925) Merge (7502734) Diff
apk (release) 2.06 MB 2.06 MB +4 B (+0.0%)
firebase-config
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 211 kB 211 kB +4 B (+0.0%)
firebase-config-interop
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 20.8 kB 20.8 kB +4 B (+0.0%)
firebase-crashlytics
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 697 kB 697 kB -140 B (-0.0%)
firebase-crashlytics-ktx
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 697 kB 697 kB -140 B (-0.0%)
firebase-database
Type Base (0605925) Merge (7502734) Diff
apk (release) 5.29 MB 5.29 MB +4 B (+0.0%)
firebase-database-collection
Type Base (0605925) Merge (7502734) Diff
apk (release) 1.86 MB 1.86 MB +4 B (+0.0%)
firebase-database-ktx
Type Base (0605925) Merge (7502734) Diff
apk (release) 5.29 MB 5.29 MB +4 B (+0.0%)
firebase-decoders-json
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 9.38 kB 9.38 kB +4 B (+0.0%)
apk (release) 26.5 kB 26.5 kB +4 B (+0.0%)
firebase-dynamic-module-support
Type Base (0605925) Merge (7502734) Diff
apk (release) 4.52 MB 4.52 MB +4 B (+0.0%)
firebase-encoders
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 9.38 kB 9.38 kB +4 B (+0.0%)
apk (release) 27.2 kB 27.2 kB +4 B (+0.0%)
firebase-encoders-json
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 20.8 kB 20.8 kB +4 B (+0.0%)
firebase-firestore-ktx
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 554 kB 554 kB +4 B (+0.0%)
firebase-functions-ktx
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 439 kB 439 kB +4 B (+0.0%)
apk (release) 5.43 MB 5.43 MB +4 B (+0.0%)
firebase-inappmessaging
Type Base (0605925) Merge (7502734) Diff
apk (release) 11.7 MB 11.7 MB +4 B (+0.0%)
firebase-perf
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 1.57 MB 1.57 MB -140 B (-0.0%)
firebase-perf-ktx
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 1.57 MB 1.57 MB -140 B (-0.0%)
firebase-sessions
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 560 kB 560 kB -140 B (-0.0%)
firebase-storage-ktx
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 399 kB 399 kB +4 B (+0.0%)
firebase-vertexai
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 1.32 MB 1.32 MB -116 B (-0.0%)
apk (release) 9.32 MB 9.32 MB -3.30 kB (-0.0%)
protolite-well-known-types
Type Base (0605925) Merge (7502734) Diff
apk (release) 1.68 MB 1.68 MB +4 B (+0.0%)
transport-api
Type Base (0605925) Merge (7502734) Diff
apk (aggressive) 9.38 kB 9.38 kB +4 B (+0.0%)
apk (release) 31.4 kB 31.4 kB +4 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/LK7ClEO972.html

google-oss-bot · 2024-08-01T23:17:34Z

Coverage Report ¹

Affected Products

firebase-database
Overall coverage changed from 50.16% (0605925) to 50.21% (7502734) by +0.04%.
Filename Base (0605925) Merge (7502734) Diff
ChildChangeAccumulator.java 83.33% 96.67% +13.33%
firebase-firestore
Overall coverage changed from 45.89% (0605925) to 45.90% (7502734) by +0.01%.
Filename Base (0605925) Merge (7502734) Diff
DeleteMutation.java 95.24% 90.48% -4.76%
LruGarbageCollector.java 93.64% 97.27% +3.64%
SetMutation.java 97.22% 94.44% -2.78%

`firebase-installations`

Overall coverage changed from ? (0605925) to 58.68% (7502734) by ?.

23 individual files with coverage change

Filename	Base (`0605925`)	Merge (`7502734`)	Diff
AutoValue_InstallationResponse.java	?	58.93%	?
AutoValue_PersistedInstallationEntry.java	?	61.18%	?
AutoValue_TokenResult.java	?	45.65%	?
AwaitListener.java	?	0.00%	?
Clock.java	?	0.00%	?
CrossProcessLock.java	?	51.85%	?
FirebaseInstallations.java	?	96.62%	?
FirebaseInstallationServiceClient.java	?	4.80%	?
FirebaseInstallationsException.java	?	78.57%	?
FirebaseInstallationsRegistrar.java	?	100.00%	?
GetAuthTokenListener.java	?	100.00%	?
GetIdListener.java	?	70.00%	?
IidStore.java	?	22.39%	?
InstallationResponse.java	?	100.00%	?
Installations.kt	?	40.00%	?
PersistedInstallation.java	?	97.01%	?
PersistedInstallationEntry.java	?	100.00%	?
RandomFidGenerator.java	?	20.00%	?
RequestLimiter.java	?	100.00%	?
StateListener.java	?	0.00%	?
SystemClock.java	?	100.00%	?
TokenResult.java	?	100.00%	?
Utils.java	?	95.00%	?

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/NOyqKHKUaR.html

google-oss-bot · 2024-08-01T23:40:13Z

Startup Time Report ¹

The report is too large (122,596 chars) to be displayed on GitHub. Please check this report on GCS.

https://storage.googleapis.com/firebase-sdk-metric-reports/dl7LI0kBhD/index.html

github-actions · 2024-10-08T07:57:45Z

Test Results

1 022 files + 974 1 022 suites +974 36m 3s ⏱️ + 34m 33s
5 809 tests + 5 331 5 787 ✅ + 5 310 22 💤 +21 0 ❌ ±0
11 703 runs +10 747 11 659 ✅ +10 705 44 💤 +42 0 ❌ ±0

Results for commit 2cf13ac. ± Comparison against base commit b1b107f.

♻️ This comment has been updated with latest results.

update targetSDK to 34

298a4c9

google-oss-bot added the size/XS label Aug 1, 2024

rlazo approved these changes Oct 8, 2024

View reviewed changes

Merge branch 'main' into davidmotson.targetSdk34

ba62763

rlazo and others added 4 commits October 8, 2024 04:07

Merge branch 'main' into davidmotson.targetSdk34

fd8afbf

ignore irrelevant linter

19189f6

Merge branch 'main' into davidmotson.targetSdk34

a71e6b9

ignore lint issue in test

2cf13ac

rlazo merged commit d6ee0d2 into main Oct 9, 2024
260 checks passed

rlazo deleted the davidmotson.targetSdk34 branch October 9, 2024 04:00

firebase locked and limited conversation to collaborators Nov 9, 2024

update targetSDK to 34 #6150

update targetSDK to 34 #6150

Uh oh!

Conversation

davidmotson commented Aug 1, 2024

Uh oh!

github-actions bot commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release note changes

Uh oh!

google-oss-bot commented Aug 1, 2024

Uh oh!

github-actions bot commented Aug 1, 2024

Unit Test Results

Uh oh!

google-oss-bot commented Aug 1, 2024

Size Report 1

Affected Products

base

firebase-annotations

firebase-appcheck-debug

firebase-appcheck-debug-testing

firebase-appcheck-interop

firebase-appdistribution

firebase-common

firebase-components

firebase-config

firebase-config-interop

firebase-crashlytics

firebase-crashlytics-ktx

firebase-database

firebase-database-collection

firebase-database-ktx

firebase-decoders-json

firebase-dynamic-module-support

firebase-encoders

firebase-encoders-json

firebase-firestore-ktx

firebase-functions-ktx

firebase-inappmessaging

firebase-perf

firebase-perf-ktx

firebase-sessions

firebase-storage-ktx

firebase-vertexai

protolite-well-known-types

transport-api

Test Logs

Uh oh!

google-oss-bot commented Aug 1, 2024

Coverage Report 1

Affected Products

firebase-database

firebase-firestore

firebase-installations

Test Logs

Uh oh!

google-oss-bot commented Aug 1, 2024

Startup Time Report 1

Uh oh!

github-actions bot commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Aug 1, 2024 •

edited

Loading

Size Report ¹

`base`

`firebase-annotations`

`firebase-appcheck-debug`

`firebase-appcheck-debug-testing`

`firebase-appcheck-interop`

`firebase-appdistribution`

`firebase-common`

`firebase-components`

`firebase-config`

`firebase-config-interop`

`firebase-crashlytics`

`firebase-crashlytics-ktx`

`firebase-database`

`firebase-database-collection`

`firebase-database-ktx`

`firebase-decoders-json`

`firebase-dynamic-module-support`

`firebase-encoders`

`firebase-encoders-json`

`firebase-firestore-ktx`

`firebase-functions-ktx`

`firebase-inappmessaging`

`firebase-perf`

`firebase-perf-ktx`

`firebase-sessions`

`firebase-storage-ktx`

`firebase-vertexai`

`protolite-well-known-types`

`transport-api`

Coverage Report ¹

`firebase-database`

`firebase-firestore`

`firebase-installations`

Startup Time Report ¹

github-actions bot commented Oct 8, 2024 •

edited

Loading