Fix sessions test app for target api 34 #6226

mrober · 2024-09-04T17:35:28Z

No description provided.

github-actions · 2024-09-04T17:35:42Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2024-09-04T17:40:38Z

Coverage Report ¹

Affected Products

firebase-sessions
Overall coverage changed from 72.69% (3ec4d00) to 72.61% (e46cc65) by -0.08%.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/9a90uehmCy.html

github-actions · 2024-09-04T17:41:10Z

Unit Test Results

  38 files +  30   38 suites +30 1m 8s ⏱️ +45s
  95 tests +  73   95 ✔️ +  73 0 💤 ±0 0 ❌ ±0
190 runs +146 190 ✔️ +146 0 💤 ±0 0 ❌ ±0

Results for commit 6b16b64. ± Comparison against base commit 3ec4d00.

google-oss-bot · 2024-09-04T17:44:51Z

Size Report ¹

Affected Products

firebase-sessions
Type Base (3ec4d00) Merge (e46cc65) Diff
aar 168 kB 168 kB +52 B (+0.0%)
apk (aggressive) 560 kB 560 kB +80 B (+0.0%)
apk (release) 5.52 MB 5.52 MB +64 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/RxSXa3IV91.html

google-oss-bot · 2024-09-04T18:04:40Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (3ec4d00) and the CI merge commit (e46cc65)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 3ec4d00: https://storage.googleapis.com/firebase-sdk-metric-reports/KsKUMCVWcp/index.html
- e46cc65: https://storage.googleapis.com/firebase-sdk-metric-reports/EPOgyeLu1m/index.html

Startup Times

`fire-cls`

Device Statistics Distributions

oriole-32

Percentile	`3ec4d00`	`e46cc65`	Diff	Significant (?)
p10	10.3 ±2 ms	10.3 ±2 ms	+16.9 μs (+0.2%)	NO
p25	10.8 ±2 ms	10.8 ±2 ms	+52.9 μs (+0.5%)	NO
p50	11.5 ±2 ms	11.6 ±2 ms	+150 μs (+1.3%)	NO
p75	12.5 ±2 ms	12.8 ±2 ms	+274 μs (+2.2%)	NO
p90	13.8 ±2 ms	14.2 ±2 ms	+382 μs (+2.8%)	NO

20 test runs in comparison

Commit	Test Runs
`3ec4d00`	2024-09-03_20:09:23.764446_lfcW 2024-09-03_20:09:23.764499_RVdK 2024-09-03_20:09:23.764510_Utki 2024-09-03_20:09:23.764518_EQXF 2024-09-03_20:09:23.764527_MQap 2024-09-03_20:09:23.764535_oWFB 2024-09-03_20:09:23.764542_zqEk 2024-09-03_20:09:23.764549_rTrR 2024-09-03_20:09:23.764557_iKzn 2024-09-03_20:09:23.764564_cJhv
`e46cc65`	2024-09-04_17:47:44.809584_zgbx 2024-09-04_17:47:44.809633_MFiH 2024-09-04_17:47:44.809644_diYV 2024-09-04_17:47:44.809652_TzNZ 2024-09-04_17:47:44.809659_ywfG 2024-09-04_17:47:44.809666_FhDy 2024-09-04_17:47:44.809680_pLbc 2024-09-04_17:47:44.809687_Ckad 2024-09-04_17:47:44.809694_UYwv 2024-09-04_17:47:44.809701_VoCV

redfin-30

Percentile	`3ec4d00`	`e46cc65`	Diff	Significant (?)
p10	13.9 ±4 ms	12.1 ±2 ms	-1.80 ms (-12.9%)	NO
p25	14.8 ±5 ms	12.7 ±2 ms	-2.08 ms (-14.0%)	NO
p50	16.0 ±6 ms	13.7 ±3 ms	-2.28 ms (-14.3%)	NO
p75	17.4 ±7 ms	15.1 ±3 ms	-2.30 ms (-13.2%)	NO
p90	19.9 ±9 ms	18.3 ±6 ms	-1.61 ms (-8.1%)	NO

20 test runs in comparison

Commit	Test Runs
`3ec4d00`	2024-09-03_20:09:23.764446_lfcW 2024-09-03_20:09:23.764499_RVdK 2024-09-03_20:09:23.764510_Utki 2024-09-03_20:09:23.764518_EQXF 2024-09-03_20:09:23.764527_MQap 2024-09-03_20:09:23.764535_oWFB 2024-09-03_20:09:23.764542_zqEk 2024-09-03_20:09:23.764549_rTrR 2024-09-03_20:09:23.764557_iKzn 2024-09-03_20:09:23.764564_cJhv
`e46cc65`	2024-09-04_17:47:44.809584_zgbx 2024-09-04_17:47:44.809633_MFiH 2024-09-04_17:47:44.809644_diYV 2024-09-04_17:47:44.809652_TzNZ 2024-09-04_17:47:44.809659_ywfG 2024-09-04_17:47:44.809666_FhDy 2024-09-04_17:47:44.809680_pLbc 2024-09-04_17:47:44.809687_Ckad 2024-09-04_17:47:44.809694_UYwv 2024-09-04_17:47:44.809701_VoCV

`fire-sessions`

Device Statistics Distributions

oriole-32

Percentile	`3ec4d00`	`e46cc65`	Diff	Significant (?)
p10	2.91 ±0.8 ms	2.79 ±0.4 ms	-119 μs (-4.1%)	NO
p25	3.12 ±0.8 ms	3.01 ±0.4 ms	-111 μs (-3.6%)	NO
p50	3.48 ±0.9 ms	3.38 ±0.6 ms	-103 μs (-3.0%)	NO
p75	4.01 ±1 ms	4.06 ±0.8 ms	+49.2 μs (+1.2%)	NO
p90	4.69 ±1 ms	4.93 ±1 ms	+243 μs (+5.2%)	NO

20 test runs in comparison

Commit	Test Runs
`3ec4d00`	2024-09-03_20:09:23.764446_lfcW 2024-09-03_20:09:23.764499_RVdK 2024-09-03_20:09:23.764510_Utki 2024-09-03_20:09:23.764518_EQXF 2024-09-03_20:09:23.764527_MQap 2024-09-03_20:09:23.764535_oWFB 2024-09-03_20:09:23.764542_zqEk 2024-09-03_20:09:23.764549_rTrR 2024-09-03_20:09:23.764557_iKzn 2024-09-03_20:09:23.764564_cJhv
`e46cc65`	2024-09-04_17:47:44.809584_zgbx 2024-09-04_17:47:44.809633_MFiH 2024-09-04_17:47:44.809644_diYV 2024-09-04_17:47:44.809652_TzNZ 2024-09-04_17:47:44.809659_ywfG 2024-09-04_17:47:44.809666_FhDy 2024-09-04_17:47:44.809680_pLbc 2024-09-04_17:47:44.809687_Ckad 2024-09-04_17:47:44.809694_UYwv 2024-09-04_17:47:44.809701_VoCV

redfin-30

Percentile	`3ec4d00`	`e46cc65`	Diff	Significant (?)
p10	5.63 ±0.6 ms	5.58 ±0.9 ms	-52.4 μs (-0.9%)	NO
p25	5.88 ±0.6 ms	5.96 ±1 ms	+74.8 μs (+1.3%)	NO
p50	6.24 ±0.7 ms	6.46 ±2 ms	+216 μs (+3.5%)	NO
p75	6.75 ±0.8 ms	7.12 ±2 ms	+369 μs (+5.5%)	NO
p90	7.43 ±1 ms	8.08 ±3 ms	+649 μs (+8.7%)	NO

20 test runs in comparison

Commit	Test Runs
`3ec4d00`	2024-09-03_20:09:23.764446_lfcW 2024-09-03_20:09:23.764499_RVdK 2024-09-03_20:09:23.764510_Utki 2024-09-03_20:09:23.764518_EQXF 2024-09-03_20:09:23.764527_MQap 2024-09-03_20:09:23.764535_oWFB 2024-09-03_20:09:23.764542_zqEk 2024-09-03_20:09:23.764549_rTrR 2024-09-03_20:09:23.764557_iKzn 2024-09-03_20:09:23.764564_cJhv
`e46cc65`	2024-09-04_17:47:44.809584_zgbx 2024-09-04_17:47:44.809633_MFiH 2024-09-04_17:47:44.809644_diYV 2024-09-04_17:47:44.809652_TzNZ 2024-09-04_17:47:44.809659_ywfG 2024-09-04_17:47:44.809666_FhDy 2024-09-04_17:47:44.809680_pLbc 2024-09-04_17:47:44.809687_Ckad 2024-09-04_17:47:44.809694_UYwv 2024-09-04_17:47:44.809701_VoCV

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`3ec4d00`	`e46cc65`	Diff	Significant (?)
p10	202 ±4 ms	206 ±4 ms	+3.91 ms (+1.9%)	NO
p25	208 ±4 ms	212 ±4 ms	+3.67 ms (+1.8%)	NO
p50	215 ±3 ms	218 ±5 ms	+3.11 ms (+1.4%)	NO
p75	224 ±5 ms	228 ±7 ms	+4.34 ms (+1.9%)	NO
p90	232 ±5 ms	238 ±7 ms	+6.35 ms (+2.7%)	NO

20 test runs in comparison

Commit	Test Runs
`3ec4d00`	2024-09-03_20:09:23.764446_lfcW 2024-09-03_20:09:23.764499_RVdK 2024-09-03_20:09:23.764510_Utki 2024-09-03_20:09:23.764518_EQXF 2024-09-03_20:09:23.764527_MQap 2024-09-03_20:09:23.764535_oWFB 2024-09-03_20:09:23.764542_zqEk 2024-09-03_20:09:23.764549_rTrR 2024-09-03_20:09:23.764557_iKzn 2024-09-03_20:09:23.764564_cJhv
`e46cc65`	2024-09-04_17:47:44.809584_zgbx 2024-09-04_17:47:44.809633_MFiH 2024-09-04_17:47:44.809644_diYV 2024-09-04_17:47:44.809652_TzNZ 2024-09-04_17:47:44.809659_ywfG 2024-09-04_17:47:44.809666_FhDy 2024-09-04_17:47:44.809680_pLbc 2024-09-04_17:47:44.809687_Ckad 2024-09-04_17:47:44.809694_UYwv 2024-09-04_17:47:44.809701_VoCV

redfin-30

Percentile	`3ec4d00`	`e46cc65`	Diff	Significant (?)
p10	243 ±3 ms	266 ±6 ms	+22.4 ms (+9.2%)	MAYBE
p25	249 ±4 ms	272 ±7 ms	+23.0 ms (+9.2%)	MAYBE
p50	257 ±5 ms	280 ±8 ms	+23.3 ms (+9.1%)	MAYBE
p75	266 ±6 ms	290 ±11 ms	+24.2 ms (+9.1%)	NO
p90	280 ±9 ms	310 ±21 ms	+30.2 ms (+10.8%)	NO

20 test runs in comparison

Commit	Test Runs
`3ec4d00`	2024-09-03_20:09:23.764446_lfcW 2024-09-03_20:09:23.764499_RVdK 2024-09-03_20:09:23.764510_Utki 2024-09-03_20:09:23.764518_EQXF 2024-09-03_20:09:23.764527_MQap 2024-09-03_20:09:23.764535_oWFB 2024-09-03_20:09:23.764542_zqEk 2024-09-03_20:09:23.764549_rTrR 2024-09-03_20:09:23.764557_iKzn 2024-09-03_20:09:23.764564_cJhv
`e46cc65`	2024-09-04_17:47:44.809584_zgbx 2024-09-04_17:47:44.809633_MFiH 2024-09-04_17:47:44.809644_diYV 2024-09-04_17:47:44.809652_TzNZ 2024-09-04_17:47:44.809659_ywfG 2024-09-04_17:47:44.809666_FhDy 2024-09-04_17:47:44.809680_pLbc 2024-09-04_17:47:44.809687_Ckad 2024-09-04_17:47:44.809694_UYwv 2024-09-04_17:47:44.809701_VoCV

https://storage.googleapis.com/firebase-sdk-metric-reports/koSJ0txajK/index.html

Fix sessions test app for target api 34

6b16b64

mrober requested a review from themiswang September 4, 2024 17:35

mrober added no-changelog main-merge-ack labels Sep 4, 2024

google-oss-bot added the size/M label Sep 4, 2024

mrober enabled auto-merge (squash) September 4, 2024 17:35

themiswang approved these changes Sep 4, 2024

View reviewed changes

mrober merged commit b994bd4 into main Sep 4, 2024
40 checks passed

mrober deleted the mrober/sessions-34 branch September 4, 2024 18:26

firebase locked and limited conversation to collaborators Oct 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix sessions test app for target api 34 #6226

Fix sessions test app for target api 34 #6226

Uh oh!

mrober commented Sep 4, 2024

Uh oh!

github-actions bot commented Sep 4, 2024 •

edited

Loading

Uh oh!

google-oss-bot commented Sep 4, 2024

`firebase-sessions`

Uh oh!

github-actions bot commented Sep 4, 2024

Uh oh!

google-oss-bot commented Sep 4, 2024

`firebase-sessions`

Uh oh!

google-oss-bot commented Sep 4, 2024

`fire-cls`

`fire-sessions`

`timeToInitialDisplay`

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix sessions test app for target api 34 #6226

Fix sessions test app for target api 34 #6226

Uh oh!

Conversation

mrober commented Sep 4, 2024

Uh oh!

github-actions bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 PRs merging into main branch

Uh oh!

google-oss-bot commented Sep 4, 2024

Coverage Report 1

Affected Products

firebase-sessions

Test Logs

Uh oh!

github-actions bot commented Sep 4, 2024

Unit Test Results

Uh oh!

google-oss-bot commented Sep 4, 2024

Size Report 1

Affected Products

firebase-sessions

Test Logs

Uh oh!

google-oss-bot commented Sep 4, 2024

Startup Time Report 1

Notes

Startup Times

fire-cls

fire-sessions

timeToInitialDisplay

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Sep 4, 2024 •

edited

Loading

Coverage Report ¹

`firebase-sessions`

Size Report ¹

`firebase-sessions`

Startup Time Report ¹

`fire-cls`

`fire-sessions`

`timeToInitialDisplay`