Ignore removed entries in CHANGED_FROM_STATIC #6240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check fails if the `after` state is null. This cases only happens when the entry has been removed entirely, instead of only changed from static to non-static. There are other tests that look for those changes, so it's safe to ignore it from the CHANGED_FROM_STATIC check.
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Size Report 1Affected ProductsNo changes between base commit (2eb7cd7) and merge commit (e5171d4).Test Logs |
Coverage Report 1Affected Products
Test Logs |
VinayGuthal
approved these changes
Sep 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check fails if the
afterstate is null. This cases only happens when the entry has been removed entirely, instead of only changed from static to non-static.There are other tests that look for those changes, so it's safe to ignore it from the CHANGED_FROM_STATIC check.