Skip to content

Add vertexAI to the Bill of Materials #6260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 3, 2024
Merged

Add vertexAI to the Bill of Materials #6260

merged 4 commits into from
Oct 3, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Sep 17, 2024 •
edited
Loading

b/348631692

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

buildSrc Test Results

37 tests   37 ✔️  1m 4s ⏱️
  8 suites    0 💤
  8 files      0 ❌

Results for commit 835a141.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

Unit Test Results

  1 003 files  +     955    1 003 suites  +955   36m 12s ⏱️ + 34m 49s
  5 810 tests +  5 326    5 788 ✔️ +  5 304  21 💤 +21  1 ❌ +1 
11 552 runs  +10 584  11 509 ✔️ +10 541  42 💤 +42  1 ❌ +1 

For more details on these failures, see this check.

Results for commit e5100a0. ± Comparison against base commit bb5a4d4.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-vertexai

    TypeBase (e6b4ace)Merge (98a1b21)Diff
    aar506 kB506 kB-22 B (-0.0%)
    apk (aggressive)479 kB479 kB-8 B (-0.0%)
    apk (release)9.32 MB9.32 MB-16 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tkbhV7I5JH.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (e6b4ace) to 75.99% (98a1b21) by ?.

    68 individual files with coverage change

    FilenameBase (e6b4ace)Merge (98a1b21)Diff
    AabUpdater.java?98.36%?
    AabUpdater_Factory.java?0.00%?
    ApkInstaller.java?100.00%?
    ApkInstaller_Factory.java?0.00%?
    ApkUpdater.java?92.63%?
    ApkUpdater_Factory.java?0.00%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppDistroComponent.java?0.00%?
    AppDistroComponent_MainModule_BindContentResolverFactory.java?0.00%?
    AppIconSource.java?84.62%?
    AppIconSource_Factory.java?100.00%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?71.58%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    DaggerAppDistroComponent.java?80.56%?
    DevModeDetector.java?9.09%?
    DevModeDetector_Factory.java?100.00%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?3.39%?
    FeedbackActivity_MembersInjector.java?0.00%?
    FeedbackSender.java?84.48%?
    FeedbackSender_Factory.java?0.00%?
    FeedbackTrigger.java?61.54%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.89%?
    FirebaseAppDistributionImpl_Factory.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier.java?91.49%?
    FirebaseAppDistributionLifecycleNotifier_Factory.java?0.00%?
    FirebaseAppDistributionNotificationsManager.java?88.89%?
    FirebaseAppDistributionNotificationsManager_Factory.java?0.00%?
    FirebaseAppDistributionRegistrar.java?95.83%?
    FirebaseAppDistributionTesterApiClient.java?88.78%?
    FirebaseAppDistributionTesterApiClient_Factory.java?0.00%?
    HttpsUrlConnectionFactory.java?50.00%?
    HttpsUrlConnectionFactory_Factory.java?100.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.67%?
    LogWrapper.java?86.67%?
    NewReleaseFetcher.java?86.67%?
    NewReleaseFetcher_Factory.java?0.00%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?91.78%?
    ReleaseIdentifier_Factory.java?0.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?36.17%?
    ScreenshotTaker_Factory.java?0.00%?
    SequentialReference.java?100.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?100.00%?
    SignInStorage_Factory.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity_MembersInjector.java?0.00%?
    TaskCache.java?100.00%?
    TaskCompletionSourceCache.java?72.41%?
    TaskUtils.java?77.50%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?90.09%?
    TesterApiHttpClient_Factory.java?0.00%?
    TesterSignInManager.java?95.45%?
    TesterSignInManager_Factory.java?0.00%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskCache.java?91.30%?
    UpdateTaskImpl.java?76.32%?

  • firebase-database

    Overall coverage changed from 50.21% (e6b4ace) to 50.16% (98a1b21) by -0.04%.

    FilenameBase (e6b4ace)Merge (98a1b21)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%

  • firebase-firestore

    Overall coverage changed from 46.05% (e6b4ace) to 46.06% (98a1b21) by +0.02%.

    FilenameBase (e6b4ace)Merge (98a1b21)Diff
    LruGarbageCollector.java93.64%97.27%+3.64%

  • firebase-messaging

    Overall coverage changed from 84.39% (e6b4ace) to 84.32% (98a1b21) by -0.07%.

    FilenameBase (e6b4ace)Merge (98a1b21)Diff
    FirebaseMessaging.java77.20%76.40%-0.80%

  • firebase-ml-modeldownloader

    Overall coverage changed from ? (e6b4ace) to 83.38% (98a1b21) by ?.

    36 individual files with coverage change

    FilenameBase (e6b4ace)Merge (98a1b21)Diff
    AutoFirebaseMlLogEventEncoder.java?100.00%?
    AutoValue_FirebaseMlLogEvent.java?58.18%?
    AutoValue_FirebaseMlLogEvent_DeleteModelLogEvent.java?66.67%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent.java?65.82%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions.java?62.96%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions_ModelInfo.java?64.58%?
    AutoValue_FirebaseMlLogEvent_SystemInfo.java?63.38%?
    CustomModel.java?72.13%?
    CustomModelDownloadConditions.java?88.46%?
    CustomModelDownloadService.java?79.89%?
    CustomModelDownloadService_Factory.java?0.00%?
    CustomModel_Factory.java?0.00%?
    CustomModel_Factory_Impl.java?0.00%?
    DaggerModelDownloaderComponent.java?100.00%?
    DataTransportMlEventSender.java?100.00%?
    DataTransportMlEventSender_Factory.java?0.00%?
    DownloadType.java?100.00%?
    FirebaseMlException.java?100.00%?
    FirebaseMlLogEvent.java?97.92%?
    FirebaseMlLogger.java?88.89%?
    FirebaseMlLogger_Factory.java?0.00%?
    FirebaseModelDownloader.java?84.66%?
    FirebaseModelDownloaderRegistrar.java?100.00%?
    FirebaseModelDownloader_Factory.java?0.00%?
    ModelDownloader.kt?91.67%?
    ModelDownloaderComponent.java?25.00%?
    ModelDownloaderComponent_MainModule_AppPackageNameFactory.java?0.00%?
    ModelDownloaderComponent_MainModule_AppVersionCodeFactory.java?0.00%?
    ModelDownloaderComponent_MainModule_FirebaseOptionsFactory.java?0.00%?
    ModelDownloaderComponent_MainModule_PersistenceKeyFactory.java?0.00%?
    ModelFileDownloadService.java?88.46%?
    ModelFileDownloadService_Factory.java?0.00%?
    ModelFileManager.java?82.28%?
    ModelFileManager_Factory.java?0.00%?
    SharedPreferencesUtil.java?97.26%?
    SharedPreferencesUtil_Factory.java?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rU9On6bET0.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (120,842 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hQXH3rZa0m/index.html

@rlazo rlazo added this to the vertexai-ga milestone Sep 21, 2024
@rlazo rlazo marked this pull request as ready for review October 2, 2024 12:00
@rlazo rlazo requested review from daymxn and emilypgoogle October 2, 2024 12:00
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@rlazo rlazo enabled auto-merge (squash) October 3, 2024 17:33
@rlazo rlazo merged commit 7083c1d into main Oct 3, 2024
260 of 261 checks passed
@rlazo rlazo deleted the rl.vertex.bom branch October 3, 2024 17:42
@firebase firebase locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@emilypgoogle emilypgoogle Awaiting requested review from emilypgoogle

1 more reviewer

@daymxn daymxn daymxn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

vertexai-ga

Development

Successfully merging this pull request may close these issues.

3 participants

@rlazo @google-oss-bot @daymxn