Skip to content

Fix visibility on Firebase Functions #6269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2024
+112 −120
Merged

Fix visibility on Firebase Functions #6269

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e966708
Fix visibility on Firebase Functions
emilypgoogle Sep 17, 2024
82a6a54
API text changes
emilypgoogle Sep 18, 2024
3bd35a9
Convert test
emilypgoogle Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions firebase-functions/src/main/java/com/google/firebase/functions/FirebaseFunctions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ internal constructor(
* @return The URL.
*/
@VisibleForTesting
fun getURL(function: String): URL {
internal fun getURL(function: String): URL {
val emulatorSettings = emulatorSettings
if (emulatorSettings != null) {
urlFormat =
Expand Down Expand Up @@ -173,7 +173,11 @@ internal constructor(
* @param data Parameters to pass to the function. Can be anything encodable as JSON.
* @return A Task that will be completed when the request is complete.
*/
fun call(name: String, data: Any?, options: HttpsCallOptions): Task<HttpsCallableResult> {
internal fun call(
name: String,
data: Any?,
options: HttpsCallOptions
): Task<HttpsCallableResult> {
return providerInstalled.task
.continueWithTask(executor) { task: Task<Void>? ->
contextProvider.getContext(options.limitedUseAppCheckTokens)
Expand All @@ -195,7 +199,7 @@ internal constructor(
* @param data Parameters to pass to the function. Can be anything encodable as JSON.
* @return A Task that will be completed when the request is complete.
*/
fun call(url: URL, data: Any?, options: HttpsCallOptions): Task<HttpsCallableResult> {
internal fun call(url: URL, data: Any?, options: HttpsCallOptions): Task<HttpsCallableResult> {
return providerInstalled.task
.continueWithTask(executor) { task: Task<Void>? ->
contextProvider.getContext(options.limitedUseAppCheckTokens)
Expand Down
Loading