Skip to content

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Sep 24, 2024

It's only necessary on enums we receive from the backend, not from the ones we send.

It's only necessary on enums we receive from the backend, not from the
ones we send.
@rlazo rlazo added this to the vertexai-ga milestone Sep 24, 2024
@rlazo rlazo requested review from VinayGuthal and daymxn September 24, 2024 14:45
Copy link
Contributor

github-actions bot commented Sep 24, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 24, 2024

Coverage Report 1

Affected Products

No changes between base commit (bd157db) and merge commit (bd39730).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7AgPxB8wRd.html

Copy link
Contributor

github-actions bot commented Sep 24, 2024

Unit Test Results

  16 files  ±0    16 suites  ±0   14s ⏱️ -1s
107 tests  - 1  107 ✔️  - 1  0 💤 ±0  0 ±0 
214 runs   - 2  214 ✔️  - 2  0 💤 ±0  0 ±0 

Results for commit afd9c71. ± Comparison against base commit bd157db.

This pull request removes 1 test.
com.google.firebase.vertexai.common.UnarySnapshotTests ‑ code execution parses correctly

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 24, 2024

Size Report 1

Affected Products

  • firebase-vertexai

    TypeBase (bd157db)Merge (bd39730)Diff
    aar487 kB464 kB-23.0 kB (-4.7%)
    apk (release)9.30 MB9.29 MB-13.6 kB (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZW1NxoIvk0.html

Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but 1 pending comment

@rlazo rlazo merged commit 6731b55 into main Sep 24, 2024
29 of 30 checks passed
@rlazo rlazo deleted the rl.missing.serializer.enum branch September 24, 2024 16:23
@firebase firebase locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants