Skip to content

Conversation

dconeybe
Copy link
Contributor

No description provided.

@dconeybe dconeybe self-assigned this Sep 25, 2024
Copy link
Contributor

github-actions bot commented Sep 25, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 25, 2024

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Unit Test Results

  48 files  +    8    48 suites  +8   1m 21s ⏱️ -7s
484 tests +175  484 ✔️ +175  0 💤 ±0  0 ±0 
968 runs  +338  968 ✔️ +338  0 💤 ±0  0 ±0 

Results for commit 0ac5f7a. ± Comparison against base commit 552132b.

This pull request removes 309 and adds 484 tests. Note that renamed tests count towards both.
com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance()
com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance(FirebaseApp, region)
com.google.firebase.remoteconfig.ConfigTests ‑ FirebaseRemoteConfigSettings builder works
com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns default value when key doesn't exist
com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns value when key exists
com.google.firebase.remoteconfig.FirebaseRemoteConfigSettingsTest ‑ toBuilder_withFieldsSet_buildsObjectWithFieldsSet
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasNoAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_callToAbtFails_activateStillSucceeds
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_configWithRolloutMetadata_storedInActivatedCacheSuccessfully
…
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ descriptor should have expected values
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ deserialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ serialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Boolean) creates an object with the expected value
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (normal cases)
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 25, 2024

… out of range on line ftl_dirs = list(...)"

This reverts commit 7546086.
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,652 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qNkD7YlI1l/index.html

@dconeybe dconeybe changed the title dataconnect: upgrade toolkit version to 1.3.9 (was 1.3.8) dataconnect: upgrade toolkit version to 1.4.0 (was 1.3.8) Sep 26, 2024
@dconeybe
Copy link
Contributor Author

I'm ignoring the failing "Health Check" github action since it appears to be a bug in macrobenchmark/commands.py rather than an indication of a legit bug. Googlers see https://chat.google.com/room/AAAAlocx6vc/2faF06G6n5U for a discussion.

@dconeybe dconeybe merged commit ff3efc7 into main Sep 27, 2024
40 of 41 checks passed
@dconeybe dconeybe deleted the dconeybe/FDCToolkit139 branch September 27, 2024 15:12
@firebase firebase locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants