Skip to content

Conversation

@dconeybe
Copy link
Contributor

The gradle plugin for Data Connect (located in firebase-dataconnect/gradleplugin) had its own, isolated libs.verisons.toml which duplicated the Kotlin version. This PR changes it to instead use the Kotlin version from the main libs.verisons.toml, in gradle/libs.verisons.toml.

Future PRs will eventually move all of the dependencies defined in firebase-dataconnect/gradleplugin/gradle/libs.versions.toml into gradle/libs.verisons.toml.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor

Unit Test Results

  1 018 files  +     970    1 018 suites  +970   36m 48s ⏱️ + 35m 22s
  5 810 tests +  5 326    5 789 ✔️ +  5 305  21 💤 +21  0 ±0 
11 705 runs  +10 737  11 663 ✔️ +10 695  42 💤 +42  0 ±0 

Results for commit 5cf8f3a. ± Comparison against base commit ff3efc7.

@dconeybe dconeybe requested review from daymxn and rlazo September 27, 2024 17:21
@dconeybe dconeybe merged commit ffcc8ba into main Sep 27, 2024
264 checks passed
@dconeybe dconeybe deleted the dconeybe/GradlePluginUseMainLibsVersionsToml branch September 27, 2024 19:17
@firebase firebase locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants