Skip to content

dataconnect: fix gradle plugin to gracefully handle schemaExtensionsOutputEnabled not being explicitly specified #6327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2024
Merged

dataconnect: fix gradle plugin to gracefully handle schemaExtensionsOutputEnabled not being explicitly specified #6327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...c/main/kotlin/com/google/firebase/dataconnect/gradle/plugin/DataConnectRunEmulatorTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import org.gradle.api.tasks.Input
import org.gradle.api.tasks.InputDirectory
import org.gradle.api.tasks.InputFile
import org.gradle.api.tasks.Internal
import org.gradle.api.tasks.Optional
import org.gradle.api.tasks.TaskAction

abstract class DataConnectRunEmulatorTask : DefaultTask() {
Expand All @@ -34,7 +35,7 @@ abstract class DataConnectRunEmulatorTask : DefaultTask() {

@get:Input abstract val postgresConnectionUrl: Property<String>

@get:Input abstract val schemaExtensionsOutputEnabled: Property<Boolean>
@get:Optional @get:Input abstract val schemaExtensionsOutputEnabled: Property<Boolean>

@get:Internal abstract val buildDirectory: DirectoryProperty

Expand All @@ -43,7 +44,7 @@ abstract class DataConnectRunEmulatorTask : DefaultTask() {
val dataConnectExecutable: File = dataConnectExecutable.get().asFile
val configDirectory: File = configDirectory.get().asFile
val postgresConnectionUrl: String = postgresConnectionUrl.get()
val schemaExtensionsOutputEnabled: Boolean = schemaExtensionsOutputEnabled.get()
val schemaExtensionsOutputEnabled: Boolean = schemaExtensionsOutputEnabled.orNull ?: false
val buildDirectory: File = buildDirectory.get().asFile

logger.info("dataConnectExecutable={}", dataConnectExecutable.absolutePath)
Expand Down
Loading