-
Notifications
You must be signed in to change notification settings - Fork 645
Fix: Vertex Fails to parse some function parameters #6332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Release note changesNo release note changes were detected. If you made changes that should be |
Generated by 🚫 Danger |
Unit Test Results 16 files - 32 16 suites - 32 15s ⏱️ - 1m 8s Results for commit b7af14d. ± Comparison against base commit bb5a4d4. This pull request removes 484 and adds 108 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Please add a description and a clearer title |
|
Please update our tests to include better tests scenarios that really exercise the conversion API. |
String parameters previously failed to parse raw due to ambiguity of the JsonFormat. The key is to not parse them as JsonElements and then convert them to strings.
That fix is here along with regression tests.