Skip to content

Conversation

@davidmotson
Copy link
Collaborator

@davidmotson davidmotson commented Oct 1, 2024

String parameters previously failed to parse raw due to ambiguity of the JsonFormat. The key is to not parse them as JsonElements and then convert them to strings.

That fix is here along with regression tests.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@davidmotson davidmotson requested a review from rlazo October 1, 2024 00:30
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Unit Test Results

  16 files   -   32    16 suites   - 32   15s ⏱️ - 1m 8s
108 tests  - 376  108 ✔️  - 376  0 💤 ±0  0 ±0 
216 runs   - 752  216 ✔️  - 752  0 💤 ±0  0 ±0 

Results for commit b7af14d. ± Comparison against base commit bb5a4d4.

This pull request removes 484 and adds 108 tests. Note that renamed tests count towards both.
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ descriptor should have expected values
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ deserialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ serialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Boolean) creates an object with the expected value
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (normal cases)
…
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.vertexai.StreamingSnapshotTests ‑ empty content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ http errors
com.google.firebase.vertexai.StreamingSnapshotTests ‑ image rejected
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid api key
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid json
com.google.firebase.vertexai.StreamingSnapshotTests ‑ long reply
com.google.firebase.vertexai.StreamingSnapshotTests ‑ malformed content
…

♻️ This comment has been updated with latest results.

@rlazo
Copy link
Collaborator

rlazo commented Oct 1, 2024

Please add a description and a clearer title

@rlazo
Copy link
Collaborator

rlazo commented Oct 1, 2024

Please update our tests to include better tests scenarios that really exercise the conversion API.

@davidmotson davidmotson changed the title Davidmotson.vertex function fix Fix: Vertex Fails to parse some function parameters Oct 1, 2024
@davidmotson davidmotson merged commit a6944a2 into main Oct 2, 2024
27 checks passed
@davidmotson davidmotson deleted the davidmotson.vertex_function_fix branch October 2, 2024 17:06
@davidmotson davidmotson restored the davidmotson.vertex_function_fix branch October 2, 2024 17:06
@davidmotson davidmotson deleted the davidmotson.vertex_function_fix branch October 2, 2024 17:06
@firebase firebase locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants