Skip to content

Conversation

@rlazo
Copy link
Collaborator

@rlazo rlazo commented Oct 7, 2024

Although the model has been ignoring the role in the content declared as part of "system_instruction", the correct value should be "system"

Although the model has been ignoring the role in the content declared
as part of "system_instruction", the correct value should be "system"
@rlazo rlazo requested review from daymxn and emilypgoogle and removed request for emilypgoogle October 7, 2024 14:47
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Javadoc Changes:
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/Content.html	2024-10-07 16:40:20.334907259 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/Content.html	2024-10-07 16:38:07.685941522 +0000
@@ -102,6 +102,27 @@
         </tbody>
       </table>
     </div>
+    <div class="devsite-table-wrapper">
+      <table class="responsive">
+        <colgroup>
+          <col width="40%">
+          <col>
+        </colgroup>
+        <thead>
+          <tr>
+            <th colspan="100%"><h3>Public methods</h3></th>
+          </tr>
+        </thead>
+        <tbody class="list">
+          <tr>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/Content.html">Content</a></code></td>
+            <td>
+              <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/Content.html#copy(kotlin.String,kotlin.collections.List)">copy</a>(<a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;role,&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/util/List.html">List</a>&lt;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/Part.html">Part</a>&gt;&nbsp;parts)</code></div>
+            </td>
+          </tr>
+        </tbody>
+      </table>
+    </div>
     <div class="list">
       <h2>Public fields</h2>
       <div class="api-item"><a name="getParts()"></a><a name="setParts()"></a><a name="getParts--"></a><a name="setParts--"></a>
@@ -149,6 +170,13 @@
         </div>
       </div>
     </div>
+    <div class="list">
+      <h2>Public methods</h2>
+      <div class="api-item"><a name="copy(kotlin.String, kotlin.collections.List)"></a><a name="copy-kotlin.String-kotlin.collections.List-"></a><a name="copy"></a>
+        <h3 class="api-name" id="copy(kotlin.String,kotlin.collections.List)">copy</h3>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/Content.html">Content</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/Content.html#copy(kotlin.String,kotlin.collections.List)">copy</a>(<a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;role,&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/util/List.html">List</a>&lt;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/Part.html">Part</a>&gt;&nbsp;parts)</pre>
+      </div>
+    </div>
   </body>
 </html>
 
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/Content.html	2024-10-07 16:40:20.328907215 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/Content.html	2024-10-07 16:38:07.679941479 +0000
@@ -81,6 +81,27 @@
         </colgroup>
         <thead>
           <tr>
+            <th colspan="100%"><h3>Public functions</h3></th>
+          </tr>
+        </thead>
+        <tbody class="list">
+          <tr>
+            <td><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Content.html">Content</a></code></td>
+            <td>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Content.html#copy(kotlin.String,kotlin.collections.List)">copy</a>(role:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>?,&nbsp;parts:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-list/index.html">List</a>&lt;<a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Part.html">Part</a>&gt;)</code></div>
+            </td>
+          </tr>
+        </tbody>
+      </table>
+    </div>
+    <div class="devsite-table-wrapper">
+      <table class="responsive">
+        <colgroup>
+          <col width="40%">
+          <col>
+        </colgroup>
+        <thead>
+          <tr>
             <th colspan="100%"><h3>Public properties</h3></th>
           </tr>
         </thead>
@@ -137,6 +158,13 @@
       </div>
     </div>
     <div class="list">
+      <h2>Public functions</h2>
+      <div class="api-item"><a name="copy(kotlin.String, kotlin.collections.List)"></a><a name="copy-kotlin.String-kotlin.collections.List-"></a><a name="copy"></a>
+        <h3 class="api-name" id="copy(kotlin.String,kotlin.collections.List)">copy</h3>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Content.html#copy(kotlin.String,kotlin.collections.List)">copy</a>(role:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>? = this.role,&nbsp;parts:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-list/index.html">List</a>&lt;<a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Part.html">Part</a>&gt; = this.parts):&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Content.html">Content</a></pre>
+      </div>
+    </div>
+    <div class="list">
       <h2>Public properties</h2>
       <div class="api-item"><a name="getParts()"></a><a name="setParts()"></a><a name="getParts--"></a><a name="setParts--"></a>
         <h3 class="api-name" id="parts()">parts</h3>

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Test Results

 20 files  +2   20 suites  +2   16s ⏱️ ±0s
112 tests +1  112 ✅ +1  0 💤 ±0  0 ❌ ±0 
224 runs  +2  224 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 0e0bc4f. ± Comparison against base commit 448adae.

♻️ This comment has been updated with latest results.

Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left a comment, but if you wanna keep as is that's fine too

@rlazo rlazo enabled auto-merge (squash) October 7, 2024 16:35
@rlazo rlazo merged commit b1da895 into main Oct 7, 2024
27 checks passed
@rlazo rlazo deleted the rl.system.instruction.role branch October 7, 2024 16:40
@firebase firebase locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants