-
Notifications
You must be signed in to change notification settings - Fork 646
Ensure system instruction content has system role #6351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the model has been ignoring the role in the content declared as part of "system_instruction", the correct value should be "system"
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/Content.html 2024-10-07 16:40:20.334907259 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/Content.html 2024-10-07 16:38:07.685941522 +0000
@@ -102,6 +102,27 @@
</tbody>
</table>
</div>
+ <div class="devsite-table-wrapper">
+ <table class="responsive">
+ <colgroup>
+ <col width="40%">
+ <col>
+ </colgroup>
+ <thead>
+ <tr>
+ <th colspan="100%"><h3>Public methods</h3></th>
+ </tr>
+ </thead>
+ <tbody class="list">
+ <tr>
+ <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/Content.html">Content</a></code></td>
+ <td>
+ <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/Content.html#copy(kotlin.String,kotlin.collections.List)">copy</a>(<a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> role, @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/util/List.html">List</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/Part.html">Part</a>> parts)</code></div>
+ </td>
+ </tr>
+ </tbody>
+ </table>
+ </div>
<div class="list">
<h2>Public fields</h2>
<div class="api-item"><a name="getParts()"></a><a name="setParts()"></a><a name="getParts--"></a><a name="setParts--"></a>
@@ -149,6 +170,13 @@
</div>
</div>
</div>
+ <div class="list">
+ <h2>Public methods</h2>
+ <div class="api-item"><a name="copy(kotlin.String, kotlin.collections.List)"></a><a name="copy-kotlin.String-kotlin.collections.List-"></a><a name="copy"></a>
+ <h3 class="api-name" id="copy(kotlin.String,kotlin.collections.List)">copy</h3>
+ <pre class="api-signature no-pretty-print">public final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/Content.html">Content</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/Content.html#copy(kotlin.String,kotlin.collections.List)">copy</a>(<a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> role, @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/util/List.html">List</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/Part.html">Part</a>> parts)</pre>
+ </div>
+ </div>
</body>
</html>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/Content.html 2024-10-07 16:40:20.328907215 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/Content.html 2024-10-07 16:38:07.679941479 +0000
@@ -81,6 +81,27 @@
</colgroup>
<thead>
<tr>
+ <th colspan="100%"><h3>Public functions</h3></th>
+ </tr>
+ </thead>
+ <tbody class="list">
+ <tr>
+ <td><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Content.html">Content</a></code></td>
+ <td>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Content.html#copy(kotlin.String,kotlin.collections.List)">copy</a>(role: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>?, parts: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-list/index.html">List</a><<a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Part.html">Part</a>>)</code></div>
+ </td>
+ </tr>
+ </tbody>
+ </table>
+ </div>
+ <div class="devsite-table-wrapper">
+ <table class="responsive">
+ <colgroup>
+ <col width="40%">
+ <col>
+ </colgroup>
+ <thead>
+ <tr>
<th colspan="100%"><h3>Public properties</h3></th>
</tr>
</thead>
@@ -137,6 +158,13 @@
</div>
</div>
<div class="list">
+ <h2>Public functions</h2>
+ <div class="api-item"><a name="copy(kotlin.String, kotlin.collections.List)"></a><a name="copy-kotlin.String-kotlin.collections.List-"></a><a name="copy"></a>
+ <h3 class="api-name" id="copy(kotlin.String,kotlin.collections.List)">copy</h3>
+ <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Content.html#copy(kotlin.String,kotlin.collections.List)">copy</a>(role: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>? = this.role, parts: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-list/index.html">List</a><<a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Part.html">Part</a>> = this.parts): <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Content.html">Content</a></pre>
+ </div>
+ </div>
+ <div class="list">
<h2>Public properties</h2>
<div class="api-item"><a name="getParts()"></a><a name="setParts()"></a><a name="getParts--"></a><a name="setParts--"></a>
<h3 class="api-name" id="parts()">parts</h3> |
Generated by 🚫 Danger |
daymxn
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Left a comment, but if you wanna keep as is that's fine too
firebase-vertexai/src/test/java/com/google/firebase/vertexai/GenerativeModelTesting.kt
Outdated
Show resolved
Hide resolved
…enerativeModelTesting.kt Co-authored-by: Daymon <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the model has been ignoring the role in the content declared as part of "system_instruction", the correct value should be "system"