-
Notifications
You must be signed in to change notification settings - Fork 642
Pipelines #6372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipelines #6372
Conversation
Release note changesNo release note changes were detected. If you made changes that should be |
Generated by 🚫 Danger |
Test Results 186 files + 166 186 suites +166 4m 22s ⏱️ + 4m 9s Results for commit ca31612. ± Comparison against base commit e125fb7. This pull request removes 114 and adds 1234 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Per [b/384956859](https://b.corp.google.com/issues/384956859), This migrates all of our root build files to `kts`. It also refactors our usages to be more inline with modern gradle practices. Furthermore, this PR also fixes the following: - [b/384956861](https://b.corp.google.com/issues/384956861) -> Provide fallback for build script names
Per [b/384990125](https://b.corp.google.com/issues/384990125), This migrates all of our `buildSrc` logic into a composite plugin called `plugins`. This PR makes no attempt to organize the code; that is out-of-scope for the PR. This PR also fixes various references to `buildSrc` (including markdown links), to avoid any breakage.
Adjusted Functions docs as well as vestigial visibility issues.
…amp to explicitly document using the `@get` and/or `@set` use-site targets on Kotlin properties (#6612)
feat(rc): Add support to set custom signals for Remote Config Custom targeting
We have been using the spotless plugin for a while already.
Per [b/391351857](https://b.corp.google.com/issues/391351857), This refactors the `VendorPlugin` and `VendorTask` to be more compliant with the gradle cache and configuration avoidance. It also adds proper task logging and documentation to both the task and the plugin. This PR also fixes the following: - [b/391352175](https://b.corp.google.com/issues/391352175) -> Rename plugin Util files to Extensions
The SDK was released as GA last year.
Replace the changed tag with deprecated for the last FDL release
Per [b/392134866](https://b.corp.google.com/issues/392134866), This implements a centralized interface for communicating with GMaven called `GMavenService`. This service implements the gradle build-service interface to provide proper parallel access, and keeps local `ConcurrentHashMap` instances to cache responses. Cached responses are on a _per-build_ basis, to avoid improper caching of dynamic data. That is, given any build- **all** tasks that utilize `GMavenService` will share the responses from GMaven; even within a parallel environment. But if the tasks are considered out-of-date and are ran again, then new requests will be made to the GMaven backend. Tests and documentation are provided for everything added as well. Note that while this PR _implements_ `GMavenService`- it does _not_ refactor the existing `GMavenHelper` and `RepositoryClient` usages to use it. That will occur in subsequent PRs, as to avoid polluting this PR. Furthermore, while there are no tests for `PomElement` directly- in a future PR that includes tests for bom generation, `PomElement` will be tested as a by-product. This PR also fixes the following: - [b/392135224](https://b.corp.google.com/issues/392135224) -> Implement centralized pom datamodel
Empty text parts go from a nuance when processed, to an exception when send to the backend. To prevent this issue, we are dropping them when parsing the response from the server.
We've updated from version 3.* to 5.*. Test were added were necessary to match the coverage in the iOS repo. A few changes (v5.1 and v5.2) don't have tests covering the new files yet
There are some considerations to how this should be finalized. Current implementation details that I've decided on which we can change: * Based on the example doc, all classes `Foo` have been renamed `InternalFoo` * All internal serialization classes, where relevant, are moved to inner classes of their API counterparts * All classes only used as child fields for serialization classes have been moved to inner classes of those classes * All `toPublic` and `toInternal` methods on API and serialization classes have been moved inside of those classes and `conversions.kt` has been mostly emptied. * A few serialization classes do not have API equivalents and are left in a `Types.kt` file Possible changes: * Change all `InternalFoo` classes to have the same name, referenced as `Foo.Internal` rather than `Foo.InternalFoo`. This will probably make the codebase feel cleaner, but I'll wait for opinions on it * Move serialization only classes out of the internal serialization classes, either to inner classes of the API classes or top level classes themselves. * For classes that have serializers, rename serializers from `InternalFooSerializer` to `Serializer` for example `Foo.InternalFoo.Serializer` or `Foo.Internal.Serializer` instead of `Foo.InternalFoo.InternalFooSerializer` or `Foo.Internal.InternalFooSerializer`
Adds the changelog entry for #6652
Per [b/393388687](https://b.corp.google.com/issues/393388687), This updates the `core-ktx` version to be `1.12.0` instead of `1.9.0`. This version was accidentally downgraded in #6584.
Auto-generated PR for cleaning up release m158 NO_RELEASE_CHANGE --------- Co-authored-by: daymxn <[email protected]> Co-authored-by: Daymon <[email protected]>
Coverage Report 1Affected Products
Test Logs |
The public api surface has changed for the subproject firebase-firestore_api.txt: The public api surface has changed for the subproject firebase-firestore: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
2 similar comments
The public api surface has changed for the subproject firebase-firestore_api.txt: The public api surface has changed for the subproject firebase-firestore: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject firebase-firestore_api.txt: The public api surface has changed for the subproject firebase-firestore: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Size Report 1Affected Products
Test Logs |
The public api surface has changed for the subproject firebase-firestore_api.txt: The public api surface has changed for the subproject firebase-firestore: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject firebase-firestore_api.txt: The public api surface has changed for the subproject firebase-firestore: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject firebase-firestore_api.txt: The public api surface has changed for the subproject firebase-firestore: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject firebase-firestore_api.txt: The public api surface has changed for the subproject firebase-firestore: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject firebase-firestore_api.txt: The public api surface has changed for the subproject firebase-firestore: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject firebase-firestore_api.txt: The public api surface has changed for the subproject firebase-firestore: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject firebase-firestore_api.txt: The public api surface has changed for the subproject firebase-firestore: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
No description provided.