Skip to content

Conversation

tom-andersen
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Test Results

  186 files  +  166    186 suites  +166   4m 22s ⏱️ + 4m 9s
1 234 tests +1 120  1 218 ✅ +1 104  16 💤 +16  0 ❌ ±0 
2 492 runs  +2 264  2 460 ✅ +2 232  32 💤 +32  0 ❌ ±0 

Results for commit ca31612. ± Comparison against base commit e125fb7.

This pull request removes 114 and adds 1234 tests. Note that renamed tests count towards both.
com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location
com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.vertexai.StreamingSnapshotTests ‑ empty content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ http errors
com.google.firebase.vertexai.StreamingSnapshotTests ‑ image rejected
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid api key
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid json
…
com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
com.google.firebase.firestore.DocumentChangeTest ‑ randomTests
com.google.firebase.firestore.DocumentChangeTest ‑ testAdditions
com.google.firebase.firestore.DocumentChangeTest ‑ testChangesWithSortOrderChange
com.google.firebase.firestore.DocumentChangeTest ‑ testDeletions
…

♻️ This comment has been updated with latest results.

daymxn and others added 23 commits December 18, 2024 16:24
Per [b/384956859](https://b.corp.google.com/issues/384956859),

This migrates all of our root build files to `kts`. It also refactors
our usages to be more inline with modern gradle practices.

Furthermore, this PR also fixes the following:

- [b/384956861](https://b.corp.google.com/issues/384956861) -> Provide
fallback for build script names
Per [b/384990125](https://b.corp.google.com/issues/384990125),

This migrates all of our `buildSrc` logic into a composite plugin called
`plugins`.

This PR makes no attempt to organize the code; that is out-of-scope for
the PR.

This PR also fixes various references to `buildSrc` (including markdown
links), to avoid any breakage.
Adjusted Functions docs as well as vestigial visibility issues.
…amp to explicitly document using the `@get` and/or `@set` use-site targets on Kotlin properties (#6612)
feat(rc): Add support to set custom signals for Remote Config Custom
targeting
We have been using the spotless plugin for a while already.
Per [b/391351857](https://b.corp.google.com/issues/391351857),

This refactors the `VendorPlugin` and `VendorTask` to be more compliant
with the gradle cache and configuration avoidance. It also adds proper
task logging and documentation to both the task and the plugin.

This PR also fixes the following:

- [b/391352175](https://b.corp.google.com/issues/391352175) -> Rename
plugin Util files to Extensions
The SDK was released as GA last year.
Replace the changed tag with deprecated for the last FDL release
Per [b/392134866](https://b.corp.google.com/issues/392134866),

This implements a centralized interface for communicating with GMaven
called `GMavenService`. This service implements the gradle build-service
interface to provide proper parallel access, and keeps local
`ConcurrentHashMap` instances to cache responses.

Cached responses are on a _per-build_ basis, to avoid improper caching
of dynamic data. That is, given any build- **all** tasks that utilize
`GMavenService` will share the responses from GMaven; even within a
parallel environment. But if the tasks are considered out-of-date and
are ran again, then new requests will be made to the GMaven backend.

Tests and documentation are provided for everything added as well.

Note that while this PR _implements_ `GMavenService`- it does _not_
refactor the existing `GMavenHelper` and `RepositoryClient` usages to
use it. That will occur in subsequent PRs, as to avoid polluting this
PR. Furthermore, while there are no tests for `PomElement` directly- in
a future PR that includes tests for bom generation, `PomElement` will be
tested as a by-product.

This PR also fixes the following:

- [b/392135224](https://b.corp.google.com/issues/392135224) -> Implement
centralized pom datamodel
Empty text parts go from a nuance when processed, to an exception when
send to the backend. To prevent this issue, we are dropping them when
parsing the response from the server.
We've updated from version 3.* to 5.*. Test were added were necessary to
match the coverage in the iOS repo.

A few changes (v5.1 and v5.2) don't have tests covering the new files
yet
There are some considerations to how this should be finalized. Current
implementation details that I've decided on which we can change:
* Based on the example doc, all classes `Foo` have been renamed
`InternalFoo`
* All internal serialization classes, where relevant, are moved to inner
classes of their API counterparts
* All classes only used as child fields for serialization classes have
been moved to inner classes of those classes
* All `toPublic` and `toInternal` methods on API and serialization
classes have been moved inside of those classes and `conversions.kt` has
been mostly emptied.
* A few serialization classes do not have API equivalents and are left
in a `Types.kt` file

Possible changes:
* Change all `InternalFoo` classes to have the same name, referenced as
`Foo.Internal` rather than `Foo.InternalFoo`. This will probably make
the codebase feel cleaner, but I'll wait for opinions on it
* Move serialization only classes out of the internal serialization
classes, either to inner classes of the API classes or top level classes
themselves.
* For classes that have serializers, rename serializers from
`InternalFooSerializer` to `Serializer` for example
`Foo.InternalFoo.Serializer` or `Foo.Internal.Serializer` instead of
`Foo.InternalFoo.InternalFooSerializer` or
`Foo.Internal.InternalFooSerializer`
Adds the changelog entry for #6652
Per [b/393388687](https://b.corp.google.com/issues/393388687),

This updates the `core-ktx` version to be `1.12.0` instead of `1.9.0`.
This version was accidentally downgraded in #6584.
Auto-generated PR for cleaning up release m158

NO_RELEASE_CHANGE

---------

Co-authored-by: daymxn <[email protected]>
Co-authored-by: Daymon <[email protected]>
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 15, 2025

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.74% (95bbf92) to 42.93% (025c0c9) by -2.80%.

    30 individual files with coverage change

    FilenameBase (95bbf92)Merge (025c0c9)Diff
    accumulators.kt?0.00%?
    CollectionReference.java31.82%30.43%-1.38%
    Constant.kt?0.00%?
    Datastore.java21.70%17.56%-4.14%
    DocumentReference.java18.49%19.33%+0.84%
    ExecutePipelineRequest.java?0.00%?
    ExecutePipelineRequestOrBuilder.java?0.00%?
    ExecutePipelineResponse.java?0.00%?
    ExecutePipelineResponseOrBuilder.java?0.00%?
    expression.kt?0.00%?
    FieldPath.java93.10%89.66%-3.45%
    FirebaseFirestore.java41.57%41.11%-0.46%
    FirestoreClient.java38.30%37.76%-0.54%
    FirestoreGrpc.java3.13%2.96%-0.17%
    FunctionOrBuilder.java?0.00%?
    LruGarbageCollector.java97.27%93.64%-3.64%
    PatchMutation.java98.39%100.00%+1.61%
    Pipeline.java?0.00%?
    Pipeline.kt?0.00%?
    PipelineOrBuilder.java?0.00%?
    PipelineProto.java?0.00%?
    RemoteStore.java88.80%87.45%-1.35%
    ResourcePath.java94.74%92.86%-1.88%
    stage.kt?0.00%?
    StructuredPipeline.java?0.00%?
    StructuredPipelineOrBuilder.java?0.00%?
    UserDataReader.java71.30%66.04%-5.26%
    Value.java41.22%33.00%-8.22%
    Values.kt?95.87%?
    VectorValue.java46.67%36.36%-10.30%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cisxo42Y9M.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_api.txt:

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.CollectionReference.pipeline() [AddedMethod]
error: Added method com.google.firebase.firestore.FieldPath.fromDotSeparatedPath(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.getDatabaseId() [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.pipeline() [AddedMethod]
error: Added class com.google.firebase.firestore.Pipeline [AddedClass]
error: Added class com.google.firebase.firestore.PipelineResult [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSource [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

2 similar comments
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_api.txt:

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.CollectionReference.pipeline() [AddedMethod]
error: Added method com.google.firebase.firestore.FieldPath.fromDotSeparatedPath(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.getDatabaseId() [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.pipeline() [AddedMethod]
error: Added class com.google.firebase.firestore.Pipeline [AddedClass]
error: Added class com.google.firebase.firestore.PipelineResult [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSource [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_api.txt:

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.CollectionReference.pipeline() [AddedMethod]
error: Added method com.google.firebase.firestore.FieldPath.fromDotSeparatedPath(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.getDatabaseId() [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.pipeline() [AddedMethod]
error: Added class com.google.firebase.firestore.Pipeline [AddedClass]
error: Added class com.google.firebase.firestore.PipelineResult [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSource [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 15, 2025

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (95bbf92)Merge (025c0c9)Diff
    aar1.45 MB1.59 MB+147 kB (+10.2%)
    apk (aggressive)556 kB559 kB+2.52 kB (+0.5%)
    apk (release)11.4 MB11.6 MB+159 kB (+1.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sPOhtuDbDS.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_api.txt:

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.CollectionReference.pipeline() [AddedMethod]
error: Added method com.google.firebase.firestore.DocumentReference.getFullPath() [AddedMethod]
error: Added method com.google.firebase.firestore.FieldPath.fromDotSeparatedPath(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.pipeline() [AddedMethod]
error: Added class com.google.firebase.firestore.Pipeline [AddedClass]
error: Added class com.google.firebase.firestore.PipelineResult [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSource [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

thatfiredev and others added 2 commits February 17, 2025 13:57
The current refdocs are somewhat confusing and may lead to assume that
the conversion happens server-side, when it's actually client side.
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_api.txt:

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.CollectionReference.pipeline() [AddedMethod]
error: Added method com.google.firebase.firestore.DocumentReference.getFullPath() [AddedMethod]
error: Added method com.google.firebase.firestore.FieldPath.fromDotSeparatedPath(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.pipeline() [AddedMethod]
error: Added class com.google.firebase.firestore.Pipeline [AddedClass]
error: Added class com.google.firebase.firestore.PipelineResult [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSource [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_api.txt:

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.CollectionReference.pipeline() [AddedMethod]
error: Added method com.google.firebase.firestore.DocumentReference.getFullPath() [AddedMethod]
error: Added method com.google.firebase.firestore.FieldPath.fromDotSeparatedPath(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.pipeline() [AddedMethod]
error: Added class com.google.firebase.firestore.Pipeline [AddedClass]
error: Added class com.google.firebase.firestore.PipelineResult [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSource [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_api.txt:

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.CollectionReference.pipeline() [AddedMethod]
error: Added method com.google.firebase.firestore.DocumentReference.getFullPath() [AddedMethod]
error: Added method com.google.firebase.firestore.FieldPath.fromDotSeparatedPath(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.pipeline() [AddedMethod]
error: Added class com.google.firebase.firestore.Pipeline [AddedClass]
error: Added class com.google.firebase.firestore.PipelineResult [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSource [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_api.txt:

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.CollectionReference.pipeline() [AddedMethod]
error: Added method com.google.firebase.firestore.DocumentReference.getFullPath() [AddedMethod]
error: Added method com.google.firebase.firestore.FieldPath.fromDotSeparatedPath(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.pipeline() [AddedMethod]
error: Added class com.google.firebase.firestore.Pipeline [AddedClass]
error: Added class com.google.firebase.firestore.PipelineResult [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSource [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_api.txt:

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.CollectionReference.pipeline() [AddedMethod]
error: Added method com.google.firebase.firestore.DocumentReference.getFullPath() [AddedMethod]
error: Added method com.google.firebase.firestore.FieldPath.fromDotSeparatedPath(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.pipeline() [AddedMethod]
error: Added class com.google.firebase.firestore.Pipeline [AddedClass]
error: Added class com.google.firebase.firestore.PipelineResult [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSource [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_api.txt:

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.CollectionReference.pipeline() [AddedMethod]
error: Added method com.google.firebase.firestore.DocumentReference.getFullPath() [AddedMethod]
error: Added method com.google.firebase.firestore.FieldPath.fromDotSeparatedPath(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.pipeline() [AddedMethod]
error: Added class com.google.firebase.firestore.Pipeline [AddedClass]
error: Added class com.google.firebase.firestore.PipelineResult [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.PipelineSource [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@tom-andersen tom-andersen changed the base branch from main to feat/pipelines February 20, 2025 16:34
@tom-andersen tom-andersen deleted the tomandersen/pipelines branch February 20, 2025 16:35
@tom-andersen tom-andersen restored the tomandersen/pipelines branch February 20, 2025 16:35
@firebase firebase locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.