-
Notifications
You must be signed in to change notification settings - Fork 653
Migrate crashlytics tests to JUnit4 #6402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Release note changesNo release note changes were detected. If you made changes that should be |
Contributor
Vertex AI Mock Responses Check
|
Contributor
rlazo
approved these changes
Oct 24, 2024
mrober
approved these changes
Nov 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/375055031,
This performs various cleanups on the integration tests for crashlytics. This should help narrow down flakey test behavior, and avoid any issues that may arise from deprecated usages.
Namely, this PR does the following:
initMockstoopenMocks. There may have been broken behavior frominitMocksleakage.openMocksto properly close. There may have been leakage into other tests, which could cause false positives.AndroidJunit4usages to the new import. Some of the tests were still using the old (deprecated) version.