Skip to content

Enable import reordering in spotless #6406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Enable import reordering in spotless #6406

merged 1 commit into from
Oct 23, 2024

Conversation

@rlazo
Copy link
Collaborator

@rlazo rlazo commented Oct 23, 2024

No description provided.

@rlazo rlazo requested review from daymxn and emilypgoogle October 23, 2024 17:24
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.1

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

daymxn
daymxn reviewed Oct 23, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

Test Results

 1 022 files  ±0   1 022 suites  ±0   36m 29s ⏱️ +6s
 5 809 tests ±0   5 787 ✅ ±0  22 💤 ±0  0 ❌ ±0 
11 703 runs  ±0  11 659 ✅ ±0  44 💤 ±0  0 ❌ ±0 

Results for commit 541622b. ± Comparison against base commit 6f8851c.

♻️ This comment has been updated with latest results.

@rlazo rlazo enabled auto-merge (squash) October 23, 2024 17:53
@rlazo rlazo mentioned this pull request Oct 23, 2024
Merged
@rlazo rlazo merged commit d914904 into main Oct 23, 2024
260 of 262 checks passed
@rlazo rlazo deleted the rl.spotless.import.reorder branch October 23, 2024 18:05
@firebase firebase locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@emilypgoogle emilypgoogle Awaiting requested review from emilypgoogle

1 more reviewer

@daymxn daymxn daymxn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rlazo @google-oss-bot @daymxn