Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/377292172,
This fixes the issue with source jars not being published. Android variants are configured at configuration time, but
withSourcesJaris only a function. There's no way to provide aProviderto defer setting it. Attempting to instead call it after evaluation will result in it not actually being set.Previously, we published sources jars regardless if
publishSourceswas set to false. Furthermore, no SDK actually had it set to false anyhow.So moving forward, I've just removed the setting entirely- as it wasn't really being used, it fixes our issue, and reduces maintenance costs.
NO_RELEASE_CHANGE