Skip to content

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Nov 7, 2024

This PR updates the Data Connect plugin to optionally invoke ktfmt to format the generated code.

This was more of an "experiment" than anything, to see if we ultimately ship a gradle plugin to customers if we can make the generated code look "nicer". Turns out, it works! However, in its current state, customers would be required to download the ktfmt JAR manually and set the path to it. A version that actually got shipped to customers could run ktfmt in-process, like how https://github.com/cortinico/ktfmt-gradle does it. Or, it could download ktfmt on-demand, like it already does for the data connect cli binary.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Test Results

   54 files  + 34     54 suites  +34   2m 8s ⏱️ + 1m 53s
  515 tests +402    514 ✅ +401  1 💤 +1  0 ❌ ±0 
1 030 runs  +804  1 028 ✅ +802  2 💤 +2  0 ❌ ±0 

Results for commit fdd0922. ± Comparison against base commit 9754546.

This pull request removes 113 and adds 515 tests. Note that renamed tests count towards both.
com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location
com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.vertexai.StreamingSnapshotTests ‑ empty content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ http errors
com.google.firebase.vertexai.StreamingSnapshotTests ‑ image rejected
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid api key
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid json
…
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ descriptor should have expected values
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ deserialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ serialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Boolean) creates an object with the expected value
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (normal cases)
…

♻️ This comment has been updated with latest results.

@dconeybe dconeybe merged commit 6bee142 into main Nov 7, 2024
41 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/gradleplugin/ktfmtsupport branch November 7, 2024 17:01
@firebase firebase locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants