Skip to content

Conversation

dconeybe
Copy link
Contributor

This PR adds two new classes to the Data Connect SDK Public API:

  • JavaTimeLocalDateSerializer
  • KotlinxDatetimeLocalDateSerializer

These classes enable using the standard "local date" classes java.time.LocalDate and/or kotlinx.datetime.LocalDate instead of the bespoke com.google.firebase.dataconnect.LocalDate class for Date custom scalar GraphQL fields.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-dataconnect
### {{data_connect_short}} version 16.0.0-beta03 {: #data-connect_v16-0-0-beta03}

* {{changed}} Requires Data Connect emulator version 1.6.1 or later for code generation.

* {{feature}} QueryRef and MutationRef gain methods copy(), withDataDeserializer(),
  and withVariablesSerializer().
  (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external})

* {{feature}} GeneratedConnector gains methods copy(), operations(), queries(),
  and mutations().
  (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external})

* {{feature}} GeneratedQuery and GeneratedMutation gain methods copy(),
  withVariablesSerializer(), and withDataDeserializer().
  (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external})

* {{feature}} GeneratedConnector, GeneratedQuery, and GeneratedMutation now
  must implement equals() to be a _logical_ comparsion, rather than just
  checking for _referencial_ equality using the `===` operator.
  (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external})

* {{feature}} ExperimentalFirebaseDataConnect annotation added, and some
  APIs have been annotated with it, requiring applications that make use of
  these experimental APIs to opt-in using
  `@OptIn(ExperimentalFirebaseDataConnect::class)` to suppress warnings or
  errors related to using these experimental APIs.
  (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external}) and
  (GitHub [#6433](//github.com/firebase/firebase-android-sdk/issues/6433){: .external})

* {{changed}} Replaced java.util.Date with
  com.google.firebase.dataconnect.LocalDate.
  (GitHub [#6434](//github.com/firebase/firebase-android-sdk/issues/6434){: .external})

* {{changed}} `DateSerializer` removed, as it is superceded by
  `LocalDateSerializer`. As of Data Connect emulator version 1.7.0, the
  generated Kotlin code uses `com.google.firebase.dataconnect.LocalDate`
  instead of `java.util.Date`. Therefore, this version of the SDK must be
  paired with code generated by version 1.7.0 (or later) of the Data Connect
  emulator.
  (GitHub [#6513](//github.com/firebase/firebase-android-sdk/issues/6513){: .external})

* {{feature}} JavaTimeLocalDateSerializer and KotlinxDatetimeLocalDateSerializer
  added, to enable using the standard "local date" classes `java.time.LocalDate`
  and/or `kotlinx.datetime.LocalDate` instead of the bespoke
  `com.google.firebase.dataconnect.LocalDate` class for `Date` GraphQL fields
  and variables.
  (GitHub [#6519](//github.com/firebase/firebase-android-sdk/issues/6519){: .external})

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

Copy link
Contributor

github-actions bot commented Nov 15, 2024

Test Results

   62 files  + 4     62 suites  +4   2m 17s ⏱️ +14s
  541 tests + 6    540 ✅ + 6  1 💤 ±0  0 ❌ ±0 
1 082 runs  +12  1 080 ✅ +12  2 💤 ±0  0 ❌ ±0 

Results for commit b6d45f8. ± Comparison against base commit 9299c6d.

♻️ This comment has been updated with latest results.

@dconeybe dconeybe merged commit 39e7c92 into main Nov 15, 2024
36 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/JavaTimeKotlinxDatetime branch November 15, 2024 17:55
@firebase firebase locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants