Skip to content

dataconnect: tests: increase tag size from 20 to 50 characters, to reduce the chance of collisions #6521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

dataconnect: tests: increase tag size from 20 to 50 characters, to reduce the chance of collisions #6521

merged 1 commit into from
Nov 18, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Nov 15, 2024 •
edited
Loading

This PR only affects the unit and integration tests; nothing in this PR affects production behavior.

@dconeybe dconeybe self-assigned this Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@github-actions GitHub Actions
Copy link
Contributor

Test Results

   58 files  ±0     58 suites  ±0   2m 19s ⏱️ +16s
  535 tests ±0    534 ✅ ±0  1 💤 ±0  0 ❌ ±0 
1 070 runs  ±0  1 068 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 60f45da. ± Comparison against base commit 9299c6d.

@dconeybe dconeybe changed the title dataconnect: tests: increase tag size fro 20 to 50 characters, to reduce the chance of collisions dataconnect: tests: increase tag size from 20 to 50 characters, to reduce the chance of collisions Nov 18, 2024
@dconeybe dconeybe merged commit 4bc552f into main Nov 18, 2024
41 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/ArbsIncreaseTagSize branch November 18, 2024 21:43
@firebase firebase locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aashishpatil-g aashishpatil-g aashishpatil-g approved these changes

Assignees

@dconeybe dconeybe

Labels

api: dataconnect main-merge-ack no-changelog size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dconeybe @aashishpatil-g @google-oss-bot