Skip to content

Address warning in FirebaseAppGetDetector #6542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Address warning in FirebaseAppGetDetector #6542

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd2e575
Address warning in FirebaseAppGetDetector
rlazo Nov 28, 2024
ca8831d
Merge branch 'main' into rl.app.get.detector
rlazo Nov 29, 2024
885ccf8
Merge branch 'main' into rl.app.get.detector
rlazo Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tools/lint/src/main/kotlin/FirebaseAppGetDetector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,19 @@ import org.jetbrains.uast.getParentOfType
class FirebaseAppGetDetector : Detector(), SourceCodeScanner {
override fun getApplicableMethodNames(): List<String> = listOf("get")

override fun visitMethodCall(context: JavaContext, call: UCallExpression, method: PsiMethod) {
override fun visitMethodCall(context: JavaContext, node: UCallExpression, method: PsiMethod) {
if (!isFirebaseAppGet(method)) {
return
}

if (withinGetInstance(call)) {
if (withinGetInstance(node)) {
return
}
call.getParentOfType<UMethod>() ?: return
node.getParentOfType<UMethod>() ?: return
context.report(
ISSUE,
call,
context.getCallLocation(call, includeReceiver = false, includeArguments = true),
node,
context.getCallLocation(node, includeReceiver = false, includeArguments = true),
"Use of FirebaseApp#get(Class) is discouraged, and is only acceptable" +
" in SDK#getInstance(...) methods. Instead declare dependencies explicitly in" +
" your ComponentRegistrar and inject."
Expand Down
Loading