Skip to content

Use right configuration to set name and email for sync #6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use right configuration to set name and email for sync #6555

wants to merge 1 commit into from

Conversation

@rlazo
Copy link
Collaborator

@rlazo rlazo commented Dec 3, 2024

No description provided.

@rlazo rlazo requested a review from davidmotson December 3, 2024 21:12
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@rlazo rlazo requested a review from daymxn December 3, 2024 21:12
@rlazo rlazo enabled auto-merge (squash) December 3, 2024 21:12
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Test Results

 1 036 files  +   998   1 036 suites  +998   32m 57s ⏱️ + 32m 1s
 5 873 tests + 5 778   5 851 ✅ + 5 756  22 💤 +22  0 ❌ ±0 
11 831 runs  +11 641  11 787 ✅ +11 597  44 💤 +44  0 ❌ ±0 

Results for commit 4ae7422. ± Comparison against base commit 5628212.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (5628212) and merge commit (7c8f961).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MIdTsmcunB.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.21% (5628212) to 50.16% (7c8f961) by -0.04%.

    FilenameBase (5628212)Merge (7c8f961)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%

  • firebase-messaging

    Overall coverage changed from 84.12% (5628212) to 84.15% (7c8f961) by +0.04%.

    FilenameBase (5628212)Merge (7c8f961)Diff
    FirebaseMessaging.java76.40%76.00%-0.40%
    RequestDeduplicator.java80.00%90.00%+10.00%

  • firebase-storage

    Overall coverage changed from 83.92% (5628212) to 84.08% (7c8f961) by +0.17%.

    FilenameBase (5628212)Merge (7c8f961)Diff
    NetworkRequest.java87.29%87.85%+0.55%
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.69%+0.30%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AN4lKfSycx.html

@rlazo
Copy link
Collaborator Author

rlazo commented Dec 3, 2024

As discussed offline, will reverse the logic so operations affecting one repo happen from the repo itself.

@rlazo rlazo closed this Dec 3, 2024
auto-merge was automatically disabled December 3, 2024 22:22

Pull request was closed

@firebase firebase locked and limited conversation to collaborators Jan 3, 2025
@rlazo rlazo deleted the rl.sync.redo branch August 16, 2025 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidmotson davidmotson Awaiting requested review from davidmotson

@daymxn daymxn Awaiting requested review from daymxn

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rlazo @google-oss-bot