Skip to content

dataconnect: demo: upgrade firebase-tools to v13.28.0 #6577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2024
Merged

dataconnect: demo: upgrade firebase-tools to v13.28.0 #6577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1745c9b
upgrade firebase-tools to v13.28.0 (was v13.25.0)
dconeybe Dec 6, 2024
eab02d0
Merge branch 'main' into dconeybe/dataconnect/demoapp_firebase_tools_…
dconeybe Dec 7, 2024
f7550a9
Merge branch 'main' into dconeybe/dataconnect/demoapp_firebase_tools_…
dconeybe Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dataconnect_demo_app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ on:

env:
FDC_NODE_VERSION: ${{ inputs.nodeVersion || '20' }}
FDC_FIREBASE_TOOLS_VERSION: ${{ inputs.firebaseToolsVersion || '13.25.0' }}
FDC_FIREBASE_TOOLS_VERSION: ${{ inputs.firebaseToolsVersion || '13.28.0' }}
FDC_JAVA_VERSION: ${{ inputs.javaVersion || '17' }}
FDC_FIREBASE_TOOLS_DIR: ${{ github.workspace }}/firebase-tools
FDC_FIREBASE_COMMAND: ${{ github.workspace }}/firebase-tools/node_modules/.bin/firebase
Expand Down
14 changes: 14 additions & 0 deletions firebase-dataconnect/demo/firebase/dataconnect/connector/operations.gql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,17 @@ query GetItemByKey(
any
}
}

# This mutation exists only as a workaround for b/382688278 where the following
# compiler error will otherwise result when compiling the generated code:
# Serializer has not been found for type 'java.util.UUID'. To use context
# serializer as fallback, explicitly annotate type or property with @Contextual
# This bug first appeared in v1.7.1 of the Data Connect Toolkit CLI, which
# started to be used in firebase-tools v13.26.0
# (https://github.com/firebase/firebase-tools/releases/tag/v13.26.0).
# This mutation can be removed from this file once the fix is released, which will
# likely be version 1.7.4 of the Data Connect Toolkit CLI (v13.28.1 of firebase-
# tools).
mutation WorkaroundForBug382688278( $id: UUID!) {
zwda6x9zyy_insert(data: { id: $id })
}
Loading