Skip to content

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jan 28, 2025

We've updated from version 3.* to 5.*. Test were added were necessary to match the coverage in the iOS repo.

A few changes (v5.1 and v5.2) don't have tests covering the new files yet

We've updated from version 3.* to 5.*. Test were added were necessary
to match the coverage in the iOS repo.

A few changes (v5.1 and v5.2) don't have tests covering the new files
yet
@rlazo rlazo requested review from davidmotson and daymxn January 28, 2025 21:32
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

@github-actions
Copy link
Contributor

Test Results

 20 files   -  1 014   20 suites   - 1 014   12s ⏱️ - 34m 16s
113 tests  -  5 775  113 ✅  -  5 753  0 💤  - 22  0 ❌ ±0 
226 runs   - 11 613  226 ✅  - 11 569  0 💤  - 44  0 ❌ ±0 

Results for commit fb233c1. ± Comparison against base commit b17d041.

This pull request removes 5775 tests.
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

@google-oss-bot
Copy link
Contributor

@rlazo rlazo enabled auto-merge (squash) January 28, 2025 21:57
@rlazo rlazo requested a review from emilypgoogle January 29, 2025 17:16
@rlazo rlazo merged commit f2d05d6 into main Jan 29, 2025
30 checks passed
@rlazo rlazo deleted the rl.vertex.golden.5 branch January 29, 2025 18:12
@firebase firebase locked and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants