Skip to content

Drop empty text parts when parsing the model's response #6652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Drop empty text parts when parsing the model's response #6652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/internal/util/conversions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,12 @@ internal fun com.google.firebase.vertexai.common.server.Candidate.toPublic(): Ca
internal fun com.google.firebase.vertexai.common.UsageMetadata.toPublic(): UsageMetadata =
UsageMetadata(promptTokenCount ?: 0, candidatesTokenCount ?: 0, totalTokenCount ?: 0)

internal fun com.google.firebase.vertexai.common.shared.Content.toPublic(): Content =
Content(role, parts.map { it.toPublic() })
internal fun com.google.firebase.vertexai.common.shared.Content.toPublic(): Content {
val returnedParts = parts.map { it.toPublic() }.filterNot { it is TextPart && it.text.isEmpty() }
// If all returned parts were text and empty, we coalesce them into a single one-character string
// part so the backend doesn't fail if we send this back as part of a multi-turn interaction.
return Content(role, returnedParts.ifEmpty { listOf(TextPart(" ")) })
}

internal fun com.google.firebase.vertexai.common.shared.Part.toPublic(): Part {
return when (this) {
Expand Down
Loading