Skip to content

dataconnect: fix cache key conflict on nighty integration tests runs #6667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 7, 2025
Merged

dataconnect: fix cache key conflict on nighty integration tests runs #6667

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2014354
dataconnect.yml: append the run_id to the saved cache keys
dconeybe Feb 4, 2025
93e655e
dataconnect.yml: temporarily comment out scheduling filter
dconeybe Feb 4, 2025
1a91c29
empty commit to trigger workflows
dconeybe Feb 4, 2025
a483fd3
dataconnect.yml: unconditionally save and cache too
dconeybe Feb 4, 2025
c6583dd
dataconnect.yml: uncomment temporarily-commented code
dconeybe Feb 4, 2025
2cfa624
merge main branch
dconeybe Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/dataconnect.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:
path: |
~/.gradle/caches
~/.gradle/wrapper
key: gradle-cache-jqnvfzw6w7
key: gradle-cache-jqnvfzw6w7-${{ github.run_id }}

- name: Enable KVM group permissions for Android Emulator
run: |
Expand Down Expand Up @@ -155,7 +155,7 @@ jobs:
path: |
~/.android/avd/*
~/.android/adb*
key: avd-cache-zhdsn586je-api${{ env.FDC_ANDROID_EMULATOR_API_LEVEL }}
key: avd-cache-zhdsn586je-api${{ env.FDC_ANDROID_EMULATOR_API_LEVEL }}-${{ github.run_id }}

- name: Data Connect Emulator
run: |
Expand Down Expand Up @@ -186,7 +186,6 @@ jobs:
set -eux && ./gradlew ${{ (inputs.gradleInfoLog && '--info') || '' }} :firebase-dataconnect:connectedCheck :firebase-dataconnect:connectors:connectedCheck

- uses: actions/upload-artifact@v4
if: true
with:
name: logs
path: "**/*.log"
Expand Down
Loading