Skip to content

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Feb 6, 2025

Per b/394908865,

This fixes an issue where ModuleVersion.bump() was not properly resetting the smaller version types. Additionally, this fixes some other minor issues with bom generation.

Namely, this PR also fixes:

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

github-actions bot commented Feb 6, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v6.1

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test Results

 1 034 files  ±0   1 034 suites  ±0   34m 21s ⏱️ -7s
 5 888 tests ±0   5 866 ✅ ±0  22 💤 ±0  0 ❌ ±0 
11 839 runs  ±0  11 795 ✅ ±0  44 💤 ±0  0 ❌ ±0 

Results for commit a451c99. ± Comparison against base commit b8803fc.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 6, 2025

@daymxn daymxn enabled auto-merge (squash) February 6, 2025 22:53
Copy link
Contributor

github-actions bot commented Feb 6, 2025

plugins test results

68 tests   68 ✅  1m 8s ⏱️
12 suites   0 💤
12 files     0 ❌

Results for commit a451c99.

@daymxn daymxn merged commit f98c035 into main Feb 6, 2025
263 of 264 checks passed
@daymxn daymxn deleted the daymon-fix-bom-bumping branch February 6, 2025 23:06
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.22% (b8803fc) to 50.16% (a02b6e8) by -0.05%.

    FilenameBase (b8803fc)Merge (a02b6e8)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    QueryParams.java90.36%89.76%-0.60%
  • firebase-firestore

    Overall coverage changed from 45.74% (b8803fc) to 45.75% (a02b6e8) by +0.01%.

    FilenameBase (b8803fc)Merge (a02b6e8)Diff
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.44%97.22%+2.78%
  • firebase-messaging

    Overall coverage changed from 84.12% (b8803fc) to 84.15% (a02b6e8) by +0.04%.

    FilenameBase (b8803fc)Merge (a02b6e8)Diff
    FirebaseMessaging.java75.60%76.00%+0.40%
  • firebase-storage

    Overall coverage changed from 84.29% (b8803fc) to 83.96% (a02b6e8) by -0.33%.

    FilenameBase (b8803fc)Merge (a02b6e8)Diff
    StorageException.java69.09%65.45%-3.64%
    StorageTask.java83.99%83.38%-0.60%
    StreamDownloadTask.java88.41%88.89%+0.48%
    UploadTask.java83.17%81.52%-1.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VEepDlITx2.html

@firebase firebase locked and limited conversation to collaborators Mar 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants