-
Notifications
You must be signed in to change notification settings - Fork 642
Fix ModuleVersion bumping #6679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Release note changesNo release note changes were detected. If you made changes that should be |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Vertex AI Mock Responses Check
|
Size Report 1Affected ProductsNo changes between base commit (b8803fc) and merge commit (a02b6e8).Test Logs |
plugins test results68 tests 68 ✅ 1m 8s ⏱️ Results for commit a451c99. |
Coverage Report 1Affected Products
Test Logs |
Per b/394908865,
This fixes an issue where
ModuleVersion.bump()
was not properly resetting the smaller version types. Additionally, this fixes some other minor issues with bom generation.Namely, this PR also fixes: